jyapayne/anbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cmds: enable redirection of all output to /dev/null

Browse source
This commit is contained in:
Simon Fels 2018-05-23 13:39:43 +02:00
commit cd28e45d44
1 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/anbox/cmds/launch.cpp
View file

@ -39,7 +39,6 @@ const std::chrono::seconds session_mgr_wait_interval{5};
constexpr unsigned int max_dbus_service_wait_attempts{10}; constexpr unsigned int max_dbus_service_wait_attempts{10};
const std::chrono::seconds dbus_service_wait_interval{5}; const std::chrono::seconds dbus_service_wait_interval{5};
#if 0
static int redirect_to_null(int flags, int fd) { static int redirect_to_null(int flags, int fd) {
int fd2; int fd2;
if ((fd2 = open("/dev/null", flags)) < 0) if ((fd2 = open("/dev/null", flags)) < 0)
@ -54,7 +53,6 @@ static int redirect_to_null(int flags, int fd) {
close(fd2); close(fd2);
return fd; return fd;
} }
#endif
} // namespace } // namespace
bool anbox::cmds::Launch::launch_session_manager() { bool anbox::cmds::Launch::launch_session_manager() {
@ -74,7 +72,6 @@ bool anbox::cmds::Launch::launch_session_manager() {
auto flags = core::posix::StandardStream::empty; auto flags = core::posix::StandardStream::empty;
auto child = core::posix::fork([&]() { auto child = core::posix::fork([&]() {
#if 0
// We redirect all in/out/err to /dev/null as they can't be seen // We redirect all in/out/err to /dev/null as they can't be seen
// anywhere. All logging output will directly go to syslog as we // anywhere. All logging output will directly go to syslog as we
// will become a session leader below which will get us rid of a // will become a session leader below which will get us rid of a
@ -86,8 +83,6 @@ bool anbox::cmds::Launch::launch_session_manager() {
return core::posix::exit::Status::failure; return core::posix::exit::Status::failure;
} }
#endif
// As we forked one time already we're sure that our process is // As we forked one time already we're sure that our process is
// not the session leader anymore so we can safely become the // not the session leader anymore so we can safely become the
// new one and lead the process group. // new one and lead the process group.