diff --git a/CMakeLists.txt b/CMakeLists.txt index 328aec3..957664b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -22,7 +22,7 @@ set(C_AND_CXX_WARNINGS "-pedantic -Wall -Wextra") # Some additional warnings not included by the general flags set above. set(EXTRA_C_WARNINGS "-Wcast-align -Wcast-qual -Wformat -Wredundant-decls -Wswitch-default") -set(EXTRA_CXX_WARNINGS "-Wnon-virtual-dtor -Wctor-dtor-privacy -Wold-style-cast") +set(EXTRA_CXX_WARNINGS "-Wnon-virtual-dtor -Wold-style-cast") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${C_AND_CXX_WARNINGS}") set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_C_WARNINGS}") @@ -87,12 +87,7 @@ IF(CMAKE_BUILD_TYPE MATCHES [cC][oO][vV][eE][rR][aA][gG][eE]) SET(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -ftest-coverage -fprofile-arcs" ) ENDIF(CMAKE_BUILD_TYPE MATCHES [cC][oO][vV][eE][rR][aA][gG][eE]) -# Build with system gmock and embedded gtest -set (GMOCK_INCLUDE_DIR "/usr/include/gmock/include" CACHE PATH "gmock source include directory") -set (GMOCK_SOURCE_DIR "/usr/src/gmock" CACHE PATH "gmock source directory") -set (GTEST_INCLUDE_DIR "${GMOCK_SOURCE_DIR}/gtest/include" CACHE PATH "gtest source include directory") - -add_subdirectory(${GMOCK_SOURCE_DIR} "${CMAKE_CURRENT_BINARY_DIR}/gmock") +find_package(GMock) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14 -fPIC") diff --git a/packaging/snap/snapcraft.yaml b/packaging/snap/snapcraft.yaml index 3de28bf..7f8a445 100644 --- a/packaging/snap/snapcraft.yaml +++ b/packaging/snap/snapcraft.yaml @@ -84,6 +84,7 @@ parts: - build-essential - cmake - cmake-data + - cmake-extras - debhelper - dbus - google-mock diff --git a/scripts/clean-build.sh b/scripts/clean-build.sh index 516863a..e6f6d75 100755 --- a/scripts/clean-build.sh +++ b/scripts/clean-build.sh @@ -7,6 +7,7 @@ apt-get install -qq -y \ build-essential \ cmake \ cmake-data \ + cmake-extras \ debhelper \ dbus \ git \ diff --git a/src/anbox/bridge/platform_api_skeleton.cpp b/src/anbox/bridge/platform_api_skeleton.cpp index c8eb9e2..10fe227 100644 --- a/src/anbox/bridge/platform_api_skeleton.cpp +++ b/src/anbox/bridge/platform_api_skeleton.cpp @@ -22,6 +22,10 @@ #include "anbox/wm/window_state.h" #include "anbox/logger.h" +#if defined(Status) +#undef Status +#endif // defined(Status) + #include "anbox_bridge.pb.h" namespace anbox { diff --git a/src/anbox/common/small_vector.h b/src/anbox/common/small_vector.h index 5193b1f..74f5f0d 100644 --- a/src/anbox/common/small_vector.h +++ b/src/anbox/common/small_vector.h @@ -15,6 +15,7 @@ #include #include +#include #include #include diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 37329ed..f9b17a8 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -1,3 +1,5 @@ +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-sign-compare") + include_directories( ${Boost_INCLUDE_DIRS} ${CMAKE_SOURCE_DIR} @@ -16,8 +18,8 @@ macro(ANBOX_ADD_TEST test_name src) anbox-core - gmock - gmock_main + ${GMOCK_LIBRARIES} + ${GTEST_BOTH_LIBRARIES} ${ARGN}