jyapayne/compose
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix leaky tests

Browse source 
It was mocking self.client but relying on the call to
utils.create_host_config which was not mocked. So now that function
has moved to also be on self.client we need to redefine the test
boundary, up to where we would call docker-py, not the result of
docker-py.

Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
This commit is contained in:
Mazz Mosley 2015-09-17 15:33:58 +01:00
commit 39ba2c5a7c
2 changed files with 14 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/unit/service_test.py
View file

@ -543,13 +543,13 @@ class ServiceVolumesTest(unittest.TestCase):
}
}
create_options = service._get_container_create_options(
service._get_container_create_options(
override_options={},
number=1,
)
self.assertEqual(
set(create_options['host_config']['Binds']),
set(self.mock_client.create_host_config.call_args[1]['binds']),
set([
'/host/path:/data1:rw',
'/host/path:/data2:rw',
@ -581,14 +581,14 @@ class ServiceVolumesTest(unittest.TestCase):
},
}
create_options = service._get_container_create_options(
service._get_container_create_options(
override_options={},
number=1,
previous_container=Container(self.mock_client, {'Id': '123123123'}),
)
self.assertEqual(
create_options['host_config']['Binds'],
self.mock_client.create_host_config.call_args[1]['binds'],
['/mnt/sda1/host/path:/data:rw'],
)
@ -613,4 +613,4 @@ class ServiceVolumesTest(unittest.TestCase):
).create_container()
self.assertEqual(len(create_calls), 1)
self.assertEqual(create_calls[0][1]['host_config']['Binds'], volumes)
self.assertEqual(self.mock_client.create_host_config.call_args[1]['binds'], volumes)