jyapayne/compose
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix stacktrace when handling timeout error

Browse source 
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
This commit is contained in:
Aanand Prasad 2016-07-29 17:12:40 +01:00
commit 5aeeecb6f2
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compose/cli/errors.py
View file

@ -53,7 +53,7 @@ def handle_connection_errors(client):
log_api_error(e, client.api_version) log_api_error(e, client.api_version)
raise ConnectionError() raise ConnectionError()
except (ReadTimeout, socket.timeout) as e: except (ReadTimeout, socket.timeout) as e:
log_timeout_error() log_timeout_error(client.timeout)
raise ConnectionError() raise ConnectionError()

8
tests/unit/cli/docker_client_test.py
View file

@ -42,6 +42,14 @@ class DockerClientTestCase(unittest.TestCase):
assert fake_log.error.call_count == 1 assert fake_log.error.call_count == 1
assert '123' in fake_log.error.call_args[0][0] assert '123' in fake_log.error.call_args[0][0]
with mock.patch('compose.cli.errors.log') as fake_log:
with pytest.raises(errors.ConnectionError):
with errors.handle_connection_errors(client):
raise errors.ReadTimeout()
assert fake_log.error.call_count == 1
assert '123' in fake_log.error.call_args[0][0]
def test_user_agent(self): def test_user_agent(self):
client = docker_client(os.environ) client = docker_client(os.environ)
expected = "docker-compose/{0} docker-py/{1} {2}/{3}".format( expected = "docker-compose/{0} docker-py/{1} {2}/{3}".format(