Merge pull request #1825 from aanand/dedupe-unset-env-warnings

Avoid duplicate warnings if an unset env variable is used multiple times
This commit is contained in:
mnowster 2015-08-12 15:57:04 +01:00
commit c443e95f07
3 changed files with 62 additions and 31 deletions

View file

@ -198,6 +198,30 @@ class InterpolationTest(unittest.TestCase):
}
])
@mock.patch.dict(os.environ)
def test_unset_variable_produces_warning(self):
os.environ.pop('FOO', None)
os.environ.pop('BAR', None)
config_details = config.ConfigDetails(
config={
'web': {
'image': '${FOO}',
'command': '${BAR}',
'entrypoint': '${BAR}',
},
},
working_dir='.',
filename=None,
)
with mock.patch('compose.config.interpolation.log') as log:
config.load(config_details)
self.assertEqual(2, log.warn.call_count)
warnings = sorted(args[0][0] for args in log.warn.call_args_list)
self.assertIn('BAR', warnings[0])
self.assertIn('FOO', warnings[1])
@mock.patch.dict(os.environ)
def test_invalid_interpolation(self):
with self.assertRaises(config.ConfigurationError) as cm: