From c51d53afbab679ec6e42956e39ed84ba18396190 Mon Sep 17 00:00:00 2001 From: Mazz Mosley Date: Fri, 3 Jul 2015 12:24:33 +0100 Subject: [PATCH] Fix off by one error In our circular reference check the stack was previously off by one, by not including the current service name that was calling another. Signed-off-by: Mazz Mosley --- compose/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compose/config.py b/compose/config.py index d32fe37e..9adbcfbd 100644 --- a/compose/config.py +++ b/compose/config.py @@ -149,7 +149,7 @@ class ServiceLoader(object): def make_service_dict(self, name, service_dict): if self.signature(name) in self.already_seen: - raise CircularReference(self.already_seen) + raise CircularReference(self.already_seen + [self.signature(name)]) service_dict = service_dict.copy() service_dict['name'] = name