jyapayne/compose
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use split_port for ports format check

Browse source 
Rather than implement the logic a second time, use docker-py
split_port function to test if the ports is valid.

Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
This commit is contained in:
Mazz Mosley 2015-08-07 15:26:26 +01:00
commit df74b131ff
3 changed files with 12 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/unit/config_test.py
View file

@ -76,7 +76,7 @@ class ConfigTest(unittest.TestCase):
def test_config_invalid_ports_format_validation(self):
with self.assertRaises(ConfigurationError):
for invalid_ports in [{"1": "8000"}, "whatport"]:
for invalid_ports in [{"1": "8000"}, "whatport", "625", "8000:8050"]:
config.load(
config.ConfigDetails(
{'web': {'image': 'busybox', 'ports': invalid_ports}},
@ -86,7 +86,7 @@ class ConfigTest(unittest.TestCase):
)
def test_config_valid_ports_format_validation(self):
valid_ports = [["8000", "9000"], "625", "8000:8050", ["8000/8050"]]
valid_ports = [["8000", "9000"], ["8000/8050"], ["8000"]]
for ports in valid_ports:
config.load(
config.ConfigDetails(