From 144f94da5a51423d73db370ff123e88ecd35ec93 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julian=20R=C3=BCth?= <julian.rueth@fsfe.org>
Date: Wed, 2 Oct 2019 19:38:18 +0200
Subject: [PATCH] Remove superfluous move (#84)

---
 src/libclang/namespace_parser.cpp | 6 +++---
 src/libclang/parse_functions.cpp  | 2 +-
 src/libclang/preprocessor.cpp     | 2 +-
 src/libclang/template_parser.cpp  | 2 +-
 src/libclang/type_parser.cpp      | 2 +-
 src/libclang/variable_parser.cpp  | 4 ++--
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/libclang/namespace_parser.cpp b/src/libclang/namespace_parser.cpp
index fb779d7..89d6ba5 100644
--- a/src/libclang/namespace_parser.cpp
+++ b/src/libclang/namespace_parser.cpp
@@ -126,7 +126,7 @@ std::unique_ptr<cpp_entity> detail::parse_cpp_namespace_alias(const detail::pars
     auto result = cpp_namespace_alias::build(*context.idx, get_entity_id(cur), std::move(name),
                                              std::move(target));
     context.comments.match(*result, cur);
-    return std::move(result);
+    return result;
 }
 
 std::unique_ptr<cpp_entity> detail::parse_cpp_using_directive(const detail::parse_context& context,
@@ -149,7 +149,7 @@ std::unique_ptr<cpp_entity> detail::parse_cpp_using_directive(const detail::pars
     auto target = cpp_namespace_ref(parse_ns_target_cursor(cur), std::move(target_name));
     auto result = cpp_using_directive::build(target);
     context.comments.match(*result, cur);
-    return std::move(result);
+    return result;
 }
 
 namespace
@@ -221,5 +221,5 @@ std::unique_ptr<cpp_entity> detail::parse_cpp_using_declaration(
     auto target = parse_entity_target_cursor(cur, std::move(target_name));
     auto result = cpp_using_declaration::build(std::move(target));
     context.comments.match(*result, cur);
-    return std::move(result);
+    return result;
 }
diff --git a/src/libclang/parse_functions.cpp b/src/libclang/parse_functions.cpp
index 3f02f0a..0112aca 100644
--- a/src/libclang/parse_functions.cpp
+++ b/src/libclang/parse_functions.cpp
@@ -284,5 +284,5 @@ std::unique_ptr<cpp_entity> detail::parse_cpp_static_assert(const detail::parse_
 
     auto result = cpp_static_assert::build(std::move(expr), std::move(msg));
     context.comments.match(*result, cur);
-    return std::move(result);
+    return result;
 }
diff --git a/src/libclang/preprocessor.cpp b/src/libclang/preprocessor.cpp
index 51646dc..980b7b4 100644
--- a/src/libclang/preprocessor.cpp
+++ b/src/libclang/preprocessor.cpp
@@ -135,7 +135,7 @@ ts::optional<std::string> parse_missing_file(const std::string& cur_file, const
     ++ptr;
 
     if (std::strcmp(ptr, " file not found") == 0)
-        return std::move(filename);
+        return filename;
     else
         throw libclang_error("preprocessor: unexpected diagnostic '" + msg + "'");
 }
diff --git a/src/libclang/template_parser.cpp b/src/libclang/template_parser.cpp
index 7890186..04a319d 100644
--- a/src/libclang/template_parser.cpp
+++ b/src/libclang/template_parser.cpp
@@ -114,7 +114,7 @@ std::unique_ptr<cpp_template_parameter> parse_non_type_parameter(
                                                          detail::parse_type(context, cur, type),
                                                          is_variadic, std::move(def));
     result->add_attribute(attributes);
-    return std::move(result);
+    return result;
 }
 
 std::unique_ptr<cpp_template_template_parameter> parse_template_parameter(
diff --git a/src/libclang/type_parser.cpp b/src/libclang/type_parser.cpp
index bfdf27b..05a6369 100644
--- a/src/libclang/type_parser.cpp
+++ b/src/libclang/type_parser.cpp
@@ -725,5 +725,5 @@ std::unique_ptr<cpp_entity> detail::parse_cpp_type_alias(const detail::parse_con
         result->add_attribute(detail::parse_attributes(stream));
     }
 
-    return std::move(result);
+    return result;
 }
diff --git a/src/libclang/variable_parser.cpp b/src/libclang/variable_parser.cpp
index f91c94f..cf96ceb 100644
--- a/src/libclang/variable_parser.cpp
+++ b/src/libclang/variable_parser.cpp
@@ -84,7 +84,7 @@ std::unique_ptr<cpp_entity> detail::parse_cpp_variable(const detail::parse_conte
                                                  storage_class, is_constexpr);
     context.comments.match(*result, cur);
     result->add_attribute(attributes);
-    return std::move(result);
+    return result;
 }
 
 std::unique_ptr<cpp_entity> detail::parse_cpp_member_variable(const detail::parse_context& context,
@@ -117,5 +117,5 @@ std::unique_ptr<cpp_entity> detail::parse_cpp_member_variable(const detail::pars
     }
     result->add_attribute(attributes);
     context.comments.match(*result, cur);
-    return std::move(result);
+    return result;
 }