jyapayne/dify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix handling of missing required parameters in ApiTool (#2965)

Browse source
This commit is contained in:
Yulong Wang 2024-03-26 10:53:39 +08:00 • committed by GitHub
commit 8e05261588
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
api/core/tools/tool/api_tool.py
View file

@ -148,7 +148,7 @@ class ApiTool(Tool):
value = '' value = ''
if parameter['name'] in parameters: if parameter['name'] in parameters:
value = parameters[parameter['name']] value = parameters[parameter['name']]
elif parameter['required']: elif parameter.get('required', False):
raise ToolParameterValidationError(f"Missing required parameter {parameter['name']}") raise ToolParameterValidationError(f"Missing required parameter {parameter['name']}")
else: else:
value = (parameter.get('schema', {}) or {}).get('default', '') value = (parameter.get('schema', {}) or {}).get('default', '')
@ -158,7 +158,7 @@ class ApiTool(Tool):
value = '' value = ''
if parameter['name'] in parameters: if parameter['name'] in parameters:
value = parameters[parameter['name']] value = parameters[parameter['name']]
elif parameter['required']: elif parameter.get('required', False):
raise ToolParameterValidationError(f"Missing required parameter {parameter['name']}") raise ToolParameterValidationError(f"Missing required parameter {parameter['name']}")
else: else:
value = (parameter.get('schema', {}) or {}).get('default', '') value = (parameter.get('schema', {}) or {}).get('default', '')
@ -168,7 +168,7 @@ class ApiTool(Tool):
value = '' value = ''
if parameter['name'] in parameters: if parameter['name'] in parameters:
value = parameters[parameter['name']] value = parameters[parameter['name']]
elif parameter['required']: elif parameter.get('required', False):
raise ToolParameterValidationError(f"Missing required parameter {parameter['name']}") raise ToolParameterValidationError(f"Missing required parameter {parameter['name']}")
else: else:
value = (parameter.get('schema', {}) or {}).get('default', '') value = (parameter.get('schema', {}) or {}).get('default', '')