jyapayne/dify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(node): fix unexpected extra equals sign in HTTP params (#23474)

Browse source
This commit is contained in:
ghmark675 2025-08-07 09:04:09 +08:00 • committed by GitHub
commit ad61b42494
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
api/core/workflow/nodes/http_request/executor.py
View file

@ -91,7 +91,7 @@ class Executor:
self.auth = node_data.authorization self.auth = node_data.authorization
self.timeout = timeout self.timeout = timeout
self.ssl_verify = node_data.ssl_verify self.ssl_verify = node_data.ssl_verify
self.params = [] self.params = None
self.headers = {} self.headers = {}
self.content = None self.content = None
self.files = None self.files = None
@ -139,6 +139,7 @@ class Executor:
(self.variable_pool.convert_template(key).text, self.variable_pool.convert_template(value_str).text) (self.variable_pool.convert_template(key).text, self.variable_pool.convert_template(value_str).text)
) )
if result:
self.params = result self.params = result
def _init_headers(self): def _init_headers(self):

8
api/tests/unit_tests/core/workflow/nodes/http_request/test_http_request_executor.py
View file

@ -49,7 +49,7 @@ def test_executor_with_json_body_and_number_variable():
assert executor.method == "post" assert executor.method == "post"
assert executor.url == "https://api.example.com/data" assert executor.url == "https://api.example.com/data"
assert executor.headers == {"Content-Type": "application/json"} assert executor.headers == {"Content-Type": "application/json"}
assert executor.params == [] assert executor.params is None
assert executor.json == {"number": 42} assert executor.json == {"number": 42}
assert executor.data is None assert executor.data is None
assert executor.files is None assert executor.files is None
@ -102,7 +102,7 @@ def test_executor_with_json_body_and_object_variable():
assert executor.method == "post" assert executor.method == "post"
assert executor.url == "https://api.example.com/data" assert executor.url == "https://api.example.com/data"
assert executor.headers == {"Content-Type": "application/json"} assert executor.headers == {"Content-Type": "application/json"}
assert executor.params == [] assert executor.params is None
assert executor.json == {"name": "John Doe", "age": 30, "email": "john@example.com"} assert executor.json == {"name": "John Doe", "age": 30, "email": "john@example.com"}
assert executor.data is None assert executor.data is None
assert executor.files is None assert executor.files is None
@ -157,7 +157,7 @@ def test_executor_with_json_body_and_nested_object_variable():
assert executor.method == "post" assert executor.method == "post"
assert executor.url == "https://api.example.com/data" assert executor.url == "https://api.example.com/data"
assert executor.headers == {"Content-Type": "application/json"} assert executor.headers == {"Content-Type": "application/json"}
assert executor.params == [] assert executor.params is None
assert executor.json == {"object": {"name": "John Doe", "age": 30, "email": "john@example.com"}} assert executor.json == {"object": {"name": "John Doe", "age": 30, "email": "john@example.com"}}
assert executor.data is None assert executor.data is None
assert executor.files is None assert executor.files is None
@ -245,7 +245,7 @@ def test_executor_with_form_data():
assert executor.url == "https://api.example.com/upload" assert executor.url == "https://api.example.com/upload"
assert "Content-Type" in executor.headers assert "Content-Type" in executor.headers
assert "multipart/form-data" in executor.headers["Content-Type"] assert "multipart/form-data" in executor.headers["Content-Type"]
assert executor.params == [] assert executor.params is None
assert executor.json is None assert executor.json is None
# '__multipart_placeholder__' is expected when no file inputs exist, # '__multipart_placeholder__' is expected when no file inputs exist,
# to ensure the request is treated as multipart/form-data by the backend. # to ensure the request is treated as multipart/form-data by the backend.