jyapayne/dify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Chore/Refactor] Add missing 'type' attribute on 'button' components (#26249)

Browse source 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: asukaminato0721 <30024051+asukaminato0721@users.noreply.github.com>
This commit is contained in:
Copilot 2025-09-28 13:43:43 +08:00 • committed by GitHub
commit beb1448441
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
32 changed files with 56 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

2
web/app/components/app-sidebar/app-info.tsx
View file

@ -260,7 +260,7 @@ const AppInfo = ({ expand, onlyShowDetail = false, openState = false, onDetailEx
return (
<div>
{!onlyShowDetail && (
<button
<button type="button"
onClick={() => {
if (isCurrentWorkspaceEditor)
setOpen(v => !v)

4
web/app/components/app-sidebar/sidebar-animation-issues.spec.tsx
View file

@ -51,7 +51,7 @@ const MockSidebarToggleButton = ({ expand, onToggle }: { expand: boolean; onTogg
className="shrink-0 px-4 py-3"
data-testid="toggle-section"
>
<button
<button type="button"
className='flex h-6 w-6 cursor-pointer items-center justify-center'
onClick={onToggle}
data-testid="toggle-button"
@ -66,7 +66,7 @@ const MockSidebarToggleButton = ({ expand, onToggle }: { expand: boolean; onTogg
const MockAppInfo = ({ expand }: { expand: boolean }) => {
return (
<div data-testid="app-info" data-expand={expand}>
<button className='block w-full'>
<button type="button" className='block w-full'>
{/* Container with layout mode switching - reproduces issue #3 */}
<div className={`flex rounded-lg ${expand ? 'flex-col gap-2 p-2 pb-2.5' : 'items-start justify-center gap-1 p-1'}`}>
{/* Icon container with justify-between to flex-col switch - reproduces issue #3 */}