jyapayne/dify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: enhance filename validation and extraction in FileService #16867 (#16869)

Browse source
This commit is contained in:
GuanMu 2025-03-27 16:46:10 +08:00 • committed by GitHub
commit d65da600e5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
api/services/file_service.py
View file

@ -1,5 +1,6 @@
import datetime import datetime
import hashlib import hashlib
import os
import uuid import uuid
from typing import Any, Literal, Union from typing import Any, Literal, Union
@ -38,7 +39,12 @@ class FileService:
source_url: str = "", source_url: str = "",
) -> UploadFile: ) -> UploadFile:
# get file extension # get file extension
extension = filename.split(".")[-1].lower() extension = os.path.splitext(filename)[1].lstrip(".").lower()
# check if filename contains invalid characters
if any(c in filename for c in ["/", "\\", ":", "*", "?", '"', "<", ">", "|"]):
raise ValueError("Filename contains invalid characters")
if len(filename) > 200: if len(filename) > 200:
filename = filename.split(".")[0][:200] + "." + extension filename = filename.split(".")[0][:200] + "." + extension