pylint work, #99

glymur/lib/openjp2.py

@@ -1381,7 +1381,6 @@ def write_tile(codec, tile_index, data, data_size, stream):
 
 def set_error_message(msg):
     """The openjpeg error handler has recorded an error message."""
-    global ERROR_MSG_LST
     ERROR_MSG_LST.append(msg)
 
 

glymur/lib/test/__init__.py

@@ -1 +1,3 @@
-#from .test_openjp2 import TestOpenJP2 as openjp2
+"""
+Test suite for openjp2, openjpeg low-level functionality.
+"""

glymur/lib/test/test_openjpeg.py

@@ -1,4 +1,6 @@
-#pylint:  disable-all
+"""
+Tests for OpenJPEG module.
+"""
 import ctypes
 import re
 import sys
@@ -10,43 +12,40 @@ else:
 
 import glymur
 
+# pylint: disable=E1101,R0904
 
-@unittest.skipIf(glymur.lib._openjpeg.OPENJPEG is None,
+@unittest.skipIf(glymur.lib.openjpeg.OPENJPEG is None,
                  "Missing openjpeg library.")
 class TestOpenJPEG(unittest.TestCase):
-
-    def setUp(self):
-        pass
-
-    def tearDown(self):
-        pass
+    """Test suite for openjpeg functions we choose to expose."""
 
     def test_version(self):
-        version = glymur.lib._openjpeg.version()
+        """Only versions 1.3, 1.4, and 1.5 are supported."""
+        version = glymur.lib.openjpeg.version()
         regex = re.compile('1.[345].[0-9]')
         if sys.hexversion <= 0x03020000:
             self.assertRegexpMatches(version, regex)
         else:
             self.assertRegex(version, regex)
 
-    def test_set_default_decoder_parameters(self):
-        # Verify that we properly set the default decode parameters.
-        version = glymur.lib._openjpeg.version()
+    def test_default_decoder_parameters(self):
+        """Verify that we properly set the default decode parameters."""
+        version = glymur.lib.openjpeg.version()
         minor = int(version.split('.')[1])
 
-        dp = glymur.lib._openjpeg.DecompressionParametersType()
-        glymur.lib._openjpeg.set_default_decoder_parameters(ctypes.byref(dp))
+        dcp = glymur.lib.openjpeg.DecompressionParametersType()
+        glymur.lib.openjpeg.set_default_decoder_parameters(ctypes.byref(dcp))
 
-        self.assertEqual(dp.cp_reduce, 0)
-        self.assertEqual(dp.cp_layer, 0)
-        self.assertEqual(dp.infile, b'')
-        self.assertEqual(dp.outfile, b'')
-        self.assertEqual(dp.decod_format, -1)
-        self.assertEqual(dp.cod_format, -1)
-        self.assertEqual(dp.jpwl_correct, 0)
-        self.assertEqual(dp.jpwl_exp_comps, 0)
-        self.assertEqual(dp.jpwl_max_tiles, 0)
-        self.assertEqual(dp.cp_limit_decoding, 0)
+        self.assertEqual(dcp.cp_reduce, 0)
+        self.assertEqual(dcp.cp_layer, 0)
+        self.assertEqual(dcp.infile, b'')
+        self.assertEqual(dcp.outfile, b'')
+        self.assertEqual(dcp.decod_format, -1)
+        self.assertEqual(dcp.cod_format, -1)
+        self.assertEqual(dcp.jpwl_correct, 0)
+        self.assertEqual(dcp.jpwl_exp_comps, 0)
+        self.assertEqual(dcp.jpwl_max_tiles, 0)
+        self.assertEqual(dcp.cp_limit_decoding, 0)
         if minor > 4:
             # Introduced in 1.5.x
-            self.assertEqual(dp.flags, 0)
+            self.assertEqual(dcp.flags, 0)