jyapayne/houserules
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(e2e): add solo modifier indicator smoke guard

Browse source 
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
Joey Yakimowich-Payne 2026-04-19 14:14:18 -06:00
commit 396051f5c0
No known key found for this signature in database
2 changed files with 58 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
.sisyphus/notepads/polish-t2/learnings.md
View file

@ -69,3 +69,18 @@ Probable file: add test to `solo-smoke.spec.ts` (T2 added it as the canary) or e
- Added optional `baseAttr?: ChessAttrKey` to `ModifierDescriptor` and set `hp-bonus` to `baseAttr: "Hp"`.
- Removed hardcoded `HpBonus`/`RangeBonus` aliasing from `getModifierSource`; source matching now uses `descriptor.baseAttr ?? descriptor.attrName` directly.
## [2026-04-19 14:03] Task: commit-4 solo modifier indicator e2e
- Added a solo-smoke e2e that seeds one custom profile in localStorage, selects it in the lobby picker, enters solo mode, and asserts a `modifier-indicator-*` node renders.
- Guarded lobby navigation by opening the rules drawer only when `profile-picker` is initially hidden, matching existing T2 lobby interaction patterns.
## [2026-04-19 14:07] Task: solo indicator test fixture correction
- Initial fixture used `color: "white"` and no `layoutId`; the option did not appear in the lobby picker during full e2e.
- Corrected fixture to mirror known-good T2 shape (`layoutId: "classic"`, `color: "both"`), which allows picker selection and solo badge assertion.
## [2026-04-19 14:09] Task: solo indicator test storage key mismatch
- Root cause of missing picker option: seeded localStorage key used `paratype-chess:modifier-profiles:v1`, but runtime library key is `houserules:modifier-profiles:v1`.
- Updating the key fixed profile loading in the lobby picker for the solo smoke regression.