feat(thressgame-coverage): Wave 11 (4 critical integration fixes)

Closes critical gaps surfaced by oracle gap audit:

- T70 (C1): server WS submit-choice handler now calls submitChoiceAndResume(engine, choiceId, value); both submit and timeout-default paths thread the value through the resume helper. Game state delta broadcast after resume.

- T71 (C3): fireOnRuleExpireHooks dispatcher implemented (mirrors fireOnRuleActivatedHooks pattern); engine.detachCustomDescriptor(descriptorId) method; WS custom-modifier.remove action with full integration; on-rule-expire hooks now actually fire on detach (was a public stub).

- T72 (C4): real cancel-capture via snapshot+restore. applyMove now snapshots defender's facts as LastCaptureSnapshot on GAME_ENTITY before retract; integration preset checks CaptureCancelled flag after fireOnCapturedHooks; if true, re-inserts defender facts and reverts mover's Position. Parry rule now actually undoes a capture in real play.

- T73: client-side request-choice plumbing. GameClient.dispatchServerMessage routes request-choice WS frames to a new GameClientEvent; sendSubmitChoice convenience method; useMultiplayerGame hook exposes pendingChoice + submitChoice; GameView renders RequestChoiceModal when pendingChoice is set.

Tests: 2744 -> 2774 (+30). bun run check exit 0.
This commit is contained in:
Joey Yakimowich-Payne 2026-04-26 14:49:07 -06:00
commit 48a15a6d57
No known key found for this signature in database
21 changed files with 2766 additions and 47 deletions

View file

@ -79,7 +79,11 @@
"ses_234a71fb6ffexvyikAILJb5T5V",
"ses_234a6dabaffeuQB1zQgChArKtq",
"ses_234a740d3ffe9EIQvGhSVIprrg",
"ses_2349f31ffffesMHCS2O8YUYzaB"
"ses_2349f31ffffesMHCS2O8YUYzaB",
"ses_23488f9dcffeFtCzBn3gxtN7KV",
"ses_23487dd88ffeEDMNwvBDLByD9N",
"ses_23488a4a2ffeG7nzsoF7nsvKHC",
"ses_234882ba1ffeMwDf2VAt2fGKaM"
],
"plan_name": "thressgame-coverage",
"agent": "atlas"