From 8a7c1b3f54b4b9acdb874e7db1fa83dd5cfd600c Mon Sep 17 00:00:00 2001 From: Joey Yakimowich-Payne Date: Sun, 19 Apr 2026 17:42:32 -0600 Subject: [PATCH] chore(sisyphus): mark T3 Wave 2 (15 primitives) complete + notepad updates --- .sisyphus/notepads/modifier-profiles-t3/learnings.md | 4 ++++ .sisyphus/plans/modifier-profiles-t3.md | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.sisyphus/notepads/modifier-profiles-t3/learnings.md b/.sisyphus/notepads/modifier-profiles-t3/learnings.md index 1b4e80f..e349cd9 100644 --- a/.sisyphus/notepads/modifier-profiles-t3/learnings.md +++ b/.sisyphus/notepads/modifier-profiles-t3/learnings.md @@ -20,3 +20,7 @@ - Mirrored `MODIFIER_REGISTRY` class shape exactly: private `Map`, duplicate guard throw, `register/get/list/has`, generic register call-site support. - Added `packages/chess/src/modifiers/primitives/index.ts` barrel with explicit Wave-2 side-effect-registration stub comment. - Added `packages/chess/src/modifiers/primitives/registry.test.ts` with 6 scenarios: round-trip get, duplicate throw, list order stability, `has()` accuracy, unknown kind miss, and generic type preservation at register call site. + +## [2026-04-19 17:28] Wave 2 batch B + +- Added `absorb-damage-with-attribute` primitive + tests. diff --git a/.sisyphus/plans/modifier-profiles-t3.md b/.sisyphus/plans/modifier-profiles-t3.md index 61ba63c..6d55808 100644 --- a/.sisyphus/plans/modifier-profiles-t3.md +++ b/.sisyphus/plans/modifier-profiles-t3.md @@ -294,7 +294,7 @@ Wave FINAL (4 parallel reviewers): *(Abbreviated — each task follows the same 7-section format as T1/T2. Full details TBD when executing.)* -- [ ] 1. **T3-ADR documentation** +- [x] 1. **T3-ADR documentation** **What to do**: Append T3-ADR-1 through T3-ADR-7 to `docs/adr/modifier-profiles.md`. @@ -304,7 +304,7 @@ Wave FINAL (4 parallel reviewers): **Commit**: `docs(adr): T3 custom modifier DSL architecture decisions` -- [ ] 2. **Primitive types + registry class** +- [x] 2. **Primitive types + registry class** **What to do**: Create `packages/chess/src/modifiers/primitives/types.ts` (EffectPrimitive, PrimitiveKind, parameter type families). Create `primitives/registry.ts` with `PRIMITIVE_REGISTRY` singleton. @@ -314,7 +314,7 @@ Wave FINAL (4 parallel reviewers): **Commit**: `feat(engine): primitive types and registry` -- [ ] 3. **Custom modifier descriptor types** +- [x] 3. **Custom modifier descriptor types** **What to do**: Create `packages/chess/src/modifiers/custom/types.ts` — `CustomModifierDescriptor` shape with { id, name, description, version, primitives[], targetAttrs[] }. @@ -324,7 +324,7 @@ Wave FINAL (4 parallel reviewers): **Commit**: `feat(engine): custom modifier descriptor types` -- [ ] 4-18. **15 primitive implementations** (one per primitive) +- [x] 4-18. **15 primitive implementations** (one per primitive) **Pattern** (one task per primitive): - Create `packages/chess/src/modifiers/primitives/{kind}.ts`: