jyapayne/houserules
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(modifiers): remove double-casts in registry and schema

Browse source 
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
Joey Yakimowich-Payne 2026-04-19 14:00:10 -06:00
commit c74a1fca00
No known key found for this signature in database
3 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
.sisyphus/notepads/polish-t2/learnings.md
View file

@ -59,3 +59,8 @@ Probable file: add test to `solo-smoke.spec.ts` (T2 added it as the canary) or e
- Gotcha: `bun run build` (tsup/vite) cleaned package `dist/` outputs and removed TS project-reference declarations; root `bun run check` then failed with TS6305 + missing `@paratype/rete` declarations.
- Resolution for this session: regenerate declaration outputs with `bunx tsc -b --force packages/rete packages/chess` before running the check gate; afterward `bun run check` returned PASS.
## [2026-04-19 13:54] Task: commit-2 registry cast cleanup
- Implemented the adapter path in `modifiers/registry.ts`: stored descriptors now wrap typed `apply/describe` in `unknown`-accepting closures at registration time.
- Result: removed the `descriptor as unknown as ModifierDescriptor` storage cast; `schema.ts` parse return also reduced from double-cast to `as ModifierProfile`.