Commit graph

10 commits

Author SHA1 Message Date
21838af5c1
feat(thressgame-coverage): Wave 10 (8 parity descriptors + 6 templates + perf + e2e spec)
8 parity tests (recreate ThressGame rules via descriptor JSON):
- T59 minefield: spawn mines + on-piece-entered destroys; one-shot consumption
- T60 mr_freeze: request-choice column + for-row + frozen-square spawn (lifetime moves:9)
- T61 parry: on-captured + RPS request-choice + conditional + cancel-capture
- T62 all_on_red: on-turn-start + with-probability(0.1) + BlockAllExceptKing seed (lifetime turns:5)
- T63 religious_conversion: on-move(bishop) + for-each-adjacent + set-piece-attr Color
- T64 ice_physics: on-rule-activated + for-each-piece(slider filter) + SlideMustBeMaxDistance
- T65 kamikaze: on-capture + with-probability(0.25) + for-each-adjacent + destroy-piece (king excluded)
- T66 mind_control: on-rule-activated + request-choice(forPlayer:both, LIFO stack) + for-each-piece + Color set

T67: 6 template descriptors in custom/recipes.ts (simple-mine, vampire-on-capture, frozen-column, coin-flip-restriction, religious-bishop, no-mans-land)
T68: Playwright e2e spec for 3 request-choice flows (.skip()'d pending UI integration; documents the gap)
T69: 100-marker performance budget test (p99 < 50ms via deterministic engine + perf.now timing)

Tests: 2703 -> 2740 (+37). bun run check exit 0.
2026-04-26 13:50:28 -06:00
6709403e44
feat(thressgame-coverage): Wave 9 remainder (palette + narrate + 3 ParamField renderers + Board markers)
Bundles work that wasn't included in T54's standalone commit:
- T51: palette taxonomy 6 categories
- T52: narrate.ts entries for 31 new kinds (35 new tests)
- T53: ParamSquarePicker
- T55: ParamMarkerKindEnum
- T56: ParamLifetimeConfig
- T57: Board marker overlays
- T58: RequestChoiceModal (already committed elsewhere or part of this)

(T54 ParamPiecePicker was committed in 90942bc)

Tests: 2658 -> 2703 (+45). bun run check exit 0.
2026-04-26 12:36:41 -06:00
d4931a50ee
feat(thressgame-coverage): Wave 8 (WS protocol v2 + suspended execution + request-choice)
- T43: WS protocol v2 schema; protocolVersion field; RequestChoice/SubmitChoice/ProtocolVersionMismatch messages; v1 backward-compat
- T44: server-side request-choice broadcast on push; submit-choice validation (kind/forPlayer/value-type); ordered LIFO matching
- T45: PendingChoices stack on GAME_ENTITY; pushPendingChoice/popPendingChoice/peekPendingChoice helpers; serializePendingChoice (Map<->Array roundtrip); MAX_CHOICE_DEPTH=8 enforced
- T46: submitChoiceAndResume(engine, choiceId, value); descriptor-by-id lookup; bindings restored; remaining primitives executed via runPrimitives from primitiveIndex+1
- T47: request-choice primitive; SuspendedExecution exception mechanism; dispatcher catches and stops sibling iteration; deterministic choiceId via session counter
- T48: AutoChoiceResolver test transport (answersByKind / answersById); drainPendingChoices LIFO walk
- T49: server-side choice timeout enforcement; auto-resolve to first-option-per-kind; disconnect handler (forfeit / pause)
- T50: ChoiceTimeoutPolicy on GAME_ENTITY (timeout-with-default | no-timeout); CreateGameRequest extended; default 60s

Tests: 2533 -> 2658 (+125). bun run check exit 0.
2026-04-26 12:07:10 -06:00
778ebc4129
feat(thressgame-coverage): Wave 7 (RNG + restriction + movement-replacement primitives)
RNG (uses T9 engine.rng()):
- T36: with-probability — engine.rng().next() < p ? then : else; deterministic with seed
- T37: random-pick — engine.rng().pick(from); binds via T11; deterministic

Restrictions:
- T38: must-class — { class: capture|advance|move-to, square? }; seeds MoveClassRestriction (move-gen wire-up deferred)
- T39: block-by-piece-type — appends to BlockedPieceTypes set on GAME_ENTITY (move-gen wire-up deferred)

Movement replacement (uses T8 schema attrs):
- T40: set-moves-as + set-moves-also-as — per-piece MovesAs/MovesAlsoAs override (move-gen consumption deferred)
- T41: pawn-pushes-pieces — game-level PawnPushesPiecesEnabled flag

Cross-cutting:
- T42: uniform lifetime field on seed-attribute + set-piece-attr; wired to lifetime-registry util (decrements on turn-end)

Registry: 42 -> 49 primitives (+7). Tests: 2426 -> 2533 (+107). bun run check exit 0.
2026-04-26 11:17:43 -06:00
9a7436e2ad
feat(thressgame-coverage): Wave 6 (markers + iteration primitives)
Marker primitives:
- T28: spawn-marker — wraps engine.spawnMarker (T10)
- T29: spawn-marker-pair — atomic dual spawn with mutual MarkerLinks (portals); T20 synthetic test moved to non-IMPERATIVE_KINDS placeholder
- T30: destroy-marker — fires on-marker-expire (T19) then engine.removeMarker

Iteration primitives (deterministic sort by entity id / index):
- T31: for-each-piece — filter (color/pieceType), bind via T11, recurse
- T32: for-each-square — squares='all'|number[], deterministic 0-63 default
- T33: for-each-adjacent — 8-neighbor with edge clipping, optional excludeKing/occupied filter
- T34: for-each-marker — filter (markerKind/owner), bind id, recurse
- T35: for-column + for-row — explicit index lists, dedupe + sort

Bonus infra: util/lifetime-registry.ts (will be used by T42).

Registry: 33 -> 42 primitives (+9). Tests: 2225 -> 2426 (+201). bun run check exit 0.
2026-04-26 11:00:05 -06:00
e290f350ad
feat(thressgame-coverage): Wave 5 (7 imperative primitives)
- T21: place-piece — calls engine.spawnPiece on resolved square
- T22: destroy-piece — retracts piece facts; enqueues on-captured
- T23: move-piece — updates Position + HasMoved; enqueues on-move + on-moved-onto-square
- T24: swap-pieces — atomic Position swap; enqueues 2 on-move events
- T25: convert-piece-type — changes PieceType; enqueues on-promotion (with previous-equality short-circuit)
- T26: set-piece-attr — generic attr insert (parity descriptors use heavily); lifetime field accepted but ignored in V1
- T27: cancel-capture — sets CaptureCancelled flag on GAME_ENTITY; rejects outside on-captured context

T20 test fix: synthetic suppressTriggers test moved from 'swap-pieces' kind (T24 took it) to 'spawn-marker-pair' (Wave 6 / T29 territory).

Registry: 26 -> 33 primitives. Tests: 2120 -> 2225 (+105). bun run check exit 0.
2026-04-26 10:25:58 -06:00
70a7c50613
feat(thressgame-coverage): Wave 4 (deferred dispatch + 4 new triggers + suppressTriggers)
- T15: deferred trigger queue (PendingTrigger[] + cascadeDepth on PrimitiveApplyContext); HARD_CASCADE_DEPTH=8; runtime.cascade-depth-exceeded; FIFO drain after arm; enqueueTrigger helper
- T16: on-rule-activated trigger primitive + fireOnRuleActivatedHooks; OnRuleActivatedHooks attr on GAME_ENTITY; RuleActivatedFiredFor guard on PRESET_STATE_ENTITY; chooser color in event
- T17: on-rule-expire trigger primitive + fireOnRuleExpireHooks; OnRuleExpireHooks attr; RuleExpireFiredFor guard
- T18: on-piece-entered-marker trigger + fireOnPieceEnteredMarkerHooks; OnPieceEnteredMarkerHooks attr; wired stage 7b in onAfterMove (uses T10 getMarkersAtSquare priority order)
- T19: on-marker-expire trigger + decrementMarkerLifetimes (util/marker-lifetime.ts); OnMarkerExpireHooks attr; wired stage 7c after T18
- T20: suppressTriggers flag on PrimitiveApplyContext; runPrimitives skips IMPERATIVE_KINDS under suppress; IMPERATIVE_KINDS exported from validate.ts; runPrimitives now public

Registry: 22 -> 26 primitives. Tests: 2058 -> 2120 (+62). bun run check exit 0.
2026-04-26 09:52:50 -06:00
defe56feb9
feat(thressgame-coverage): Wave 3 (binding scope + param walker + validator extensions)
- T11: PrimitiveApplyContext.bindings (immutable Map<string,BindingValue>); withBinding helper; threaded through 22 test files + triggers.ts/apply.ts
- T12: param-resolver.ts walker resolves { $var }, { ctx-attr: { entity, attr } }, { ctx-build: { col, row } } shapes; wired before primitive.apply in triggers.ts + custom/apply.ts; BindingError class
- T13: validator binding-out-of-scope check (descriptor.primitives.binding-out-of-scope); BINDING_INTRODUCING_KINDS map (8 future kinds); cycle-guarded $var walker
- T14: validator imperative-in-passive check (descriptor.primitives.imperative-in-passive, 10 IMPERATIVE_KINDS); LastModifierChooser tracking on PRESET_STATE_ENTITY (chooser-entity stub)

Tests: 2014 -> 2048 (+34). bun run check exit 0.
2026-04-26 09:10:21 -06:00
abe5bf49a8
feat(thressgame-coverage): Wave 2 (entity attrs + aura + RNG + marker factory)
- T6: 7 new entity attrs (EntityKind, MarkerKind, MarkerLifetime, MarkerOwner, MarkerLinks, RngSeed, RngStream) + registerAttrConsumer
- T7: aura compute admits markers via EntityKind discriminator (default-to-piece policy); +getEntityKind helper
- T8: 5 movement-replacement attrs (MovesAs, MovesAlsoAs, SlideMustBeMaxDistance, BlockAllExceptKing, KingExtraReach)
- T9: Mulberry32 PRNG (SeededRng) + deriveSeedFromGameId + engine.rng()/setRngSeed() with persistent RngStream advancement
- T10: engine.spawnMarker/removeMarker/getMarkersAtSquare with hardcoded priority table (portal-end<frozen-square<mine<...<blocked) + entity-id tiebreak

Tests: 1970 -> 2014 (+44). bun run check exit 0.
2026-04-26 08:33:43 -06:00
2368a24b15
feat(thressgame-coverage): Wave 0-1 foundation (ADR + baseline + harness + audits)
Wave 0:
- T0: Architectural decisions (10 sections, 215 lines) + 5-rule paper exercise

Wave 1 (parallel):
- T1: Backward-compat baseline fixture (1961 tests / 167 files snapshot + regression guard)
- T2: Determinism property-test harness (runDeterminismCheck, N=100 default, 1.7s)
- T3: State-hash util (SHA256 of session.allFacts, insertion-order independent)
- T4: Position-attr caller audit (75 prod callsites classified, 17 fixes seeded for T6/T7)
- T5: $var conflict audit (CLEAN — T12 binding shape safe)

Tests: 1961 -> 1970 (+9). bun run check exits 0. No production source modified.
2026-04-26 08:16:26 -06:00