Commit graph

3 commits

Author SHA1 Message Date
d6bc1ca2cc
feat(ui): Actions menu + royalty-transfer target selection in GameView 2026-04-21 12:04:55 -06:00
0ce500906c
feat(ui): extinction-chess target cycler in rules drawer
Feature 2 of post-epic-deferrals. Exposes extinction-chess's
configurable targetType through the in-game rules drawer so players
don't need to open devtools or call engine.presetState themselves.

UI:
  - RulesDrawer.tsx renders a 'Target: <PieceType>' chip inside the
    extinction-chess detail card when the preset is active.
    Clicking advances through pawn -> knight -> bishop -> rook ->
    queen -> king -> pawn (wraps). Plural labels ('Pawns', 'Knights',
    ...) for prose.
  - data-testid='extinction-target-cycler' on the chip for e2e.
  - New optional RulesDrawer props extinctionTarget +
    onExtinctionTargetChange; omitted props hide the cycler (no
    hard dependency on the engine).

Wiring (GameView.tsx):
  - Solo-only per plan decision 2a. Multiplayer games use the
    target set at room-creation time; the cycler doesn't render in
    MP to avoid desync (a future preset-config.update WS message
    could lift this; out of v1 scope).
  - Local useState syncs with engine.presetState via a useEffect;
    setExtinctionTarget writes back through the same state API and
    calls refresh() so legal highlights + terminal-state panels
    pick up the target flip.

Docs:
  - extinction-chess.ts docblock updated to reference the shipped
    UI surface + the MP deferral.
  - PRESET-API.md post-landing backlog: remove the 'UI cycling'
    deferral (now shipped), add the MP-target-sync deferral.

Tests:
  - 2 new rule-variants.spec.ts cases: (a) cycler cycles through
    all 6 labels when preset active, (b) cycler hidden when preset
    inactive.

Verification: 1663 unit + 89/89 e2e (87 + 2 new). Typecheck + lint
clean.

Plan: .sisyphus/plans/post-epic-deferrals.md Feature 2 complete.
2026-04-21 10:57:46 -06:00
cd7baeae0d
test(e2e): rule-variant vertical slice
Phase F.4 of the rule-variants epic.

Three end-to-end scenarios covering the full lobby -> game flow:

  1. knightmate: selecting the knightmate layout surfaces a
     'Suggested rules' chip for knightmate-rules in LayoutPicker;
     tapping activates the preset; Play Solo loads the game with
     no console errors; a pawn push resolves normally.

  2. double-move: in-game rules drawer shows a 'Multi-move'
     category section (Phase F.3 grouping); toggling double-move
     ON makes white play two consecutive half-moves before the
     turn flips to black, verified by successful drags of two
     white pieces followed by a black piece drag.

  3. suicide-chess: after establishing a capture opportunity
     (1. e4 d5), toggling suicide-chess on via the in-game rules
     drawer. White's next move: a non-capture (a2-a3) is
     rejected by filterLegalMoves; the compulsory capture
     (e4xd5) succeeds.

Scenarios 2 and 3 toggle the preset via the IN-GAME drawer
(lives in GameView.tsx) rather than the lobby — Lobby.tsx has
no rules drawer; only the layout-picker chip path is available
pre-game. Scenario 1 exercises the chip path. Deferred:
lobby-side drawer is a follow-up if richer pre-game preset
activation UX is desired.

Tests: 1651 unit + 3 new e2e = 4-test file added to e2e suite.
All 3 pass.
2026-04-21 09:49:55 -06:00