jyapayne/karax
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify updateElement

Browse source
This commit is contained in:
Roman Vishnevskii 2017-05-02 19:50:35 +07:00
commit cd78f5085f
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/karax.nim
View file

@ -222,17 +222,16 @@ proc updateElement(parent, current: Node, newNode, oldNode: VNode) =
updateElement(current, oldNode[rightOld].dom, newNode[rightNew], oldNode[rightOld]) updateElement(current, oldNode[rightOld].dom, newNode[rightNew], oldNode[rightOld])
dec rightNew dec rightNew
dec rightOld dec rightOld
var nextChildPos = rightOld + 1 var posNextElem = rightOld + 1
var isPushBack = posNextElem == oldLength
while left <= rightNew: while left <= rightNew:
if nextChildPos == oldLength: if isPushBack:
current.appendChild(vnodeToDom(newNode[left])) current.appendChild(vnodeToDom(newNode[left]))
else: else:
current.insertBefore(vnodeToDom(newNode[left]), oldNode[rightOld + 1].dom) current.insertBefore(vnodeToDom(newNode[left]), oldNode[posNextElem].dom)
# added new Node, so old state of VDOM have one more Node # added new Node, so old state of VDOM have one more Node
inc oldLength
inc left inc left
inc nextChildPos
for i in left..rightOld: for i in left..rightOld:
current.removeChild(oldNode[i].dom) current.removeChild(oldNode[i].dom)