From e94071b077d125534d8e95006c1b7c4e74171b27 Mon Sep 17 00:00:00 2001 From: Andreas Rumpf Date: Wed, 12 Jul 2017 13:23:58 +0200 Subject: [PATCH] components work without 'key' attribute set --- src/karax.nim | 6 +++--- tests/components.nim | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/karax.nim b/src/karax.nim index d5de6f5..9d74a9e 100644 --- a/src/karax.nim +++ b/src/karax.nim @@ -228,9 +228,9 @@ proc eq(a, b: VNode): EqResult = if a.text != b.text: when defined(profileKarax): inc reasons[deComponent] return different - if VComponent(a).key.isNil and VComponent(b).key.isNil: - when defined(profileKarax): inc reasons[deComponent] - return different + #if VComponent(a).key.isNil and VComponent(b).key.isNil: + # when defined(profileKarax): inc reasons[deComponent] + # return different if VComponent(a).key != VComponent(b).key: when defined(profileKarax): inc reasons[deComponent] return different diff --git a/tests/components.nim b/tests/components.nim index 99e1bed..6024689 100644 --- a/tests/components.nim +++ b/tests/components.nim @@ -54,7 +54,7 @@ proc newTextInput*(style: VStyle = VStyle(); key: cstring; result = newComponent(TextInput, render, changed=changed, updated=update) result.style = style result.value = value - result.key = key + #result.key = key when false: type