jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: job id should be returned only if event_delivery is not direct (#7540)

Browse source
This commit is contained in:
Gabriel Luiz Freitas Almeida 2025-04-09 16:13:42 -03:00 • committed by GitHub
commit 0185f74276
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/backend/base/langflow/api/v1/chat.py
View file

@ -199,7 +199,7 @@ async def build_flow(
) )
# This is required to support FE tests - we need to be able to set the event delivery to direct # This is required to support FE tests - we need to be able to set the event delivery to direct
if event_delivery == EventDeliveryType.DIRECT: if event_delivery != EventDeliveryType.DIRECT:
return {"job_id": job_id} return {"job_id": job_id}
return await get_flow_events_response( return await get_flow_events_response(
job_id=job_id, job_id=job_id,

3
src/backend/tests/unit/test_chat_endpoint.py
View file

@ -149,6 +149,7 @@ async def test_build_flow_polling(client, json_memory_chatbot_no_llm, logged_in_
# Start the build and get job_id # Start the build and get job_id
build_response = await build_flow(client, flow_id, logged_in_headers) build_response = await build_flow(client, flow_id, logged_in_headers)
assert "job_id" in build_response, f"Expected job_id in build_response, got {build_response}"
job_id = build_response["job_id"] job_id = build_response["job_id"]
assert job_id is not None assert job_id is not None
@ -166,7 +167,7 @@ async def test_build_flow_polling(client, json_memory_chatbot_no_llm, logged_in_
max_sleeps = 100 max_sleeps = 100
while True: while True:
response = await self.client.get( response = await self.client.get(
f"api/v1/build/{self.job_id}/events?stream=false", headers=self.headers f"api/v1/build/{self.job_id}/events?event_delivery=polling", headers=self.headers
) )
assert response.status_code == codes.OK assert response.status_code == codes.OK
data = response.json() data = response.json()