From 019e2b2bb443bc80d83cb990a8c6bdb1dc0deed6 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Fri, 23 Jun 2023 17:06:58 -0300 Subject: [PATCH] refactor(GenericNode): change data.type to data.node.display_name to improve semantics and readability feat(api): add display_name field to APIClassType to provide a human-readable name for the class --- src/frontend/package-lock.json | 3 +-- src/frontend/src/CustomNodes/GenericNode/index.tsx | 4 ++-- src/frontend/src/types/api/index.ts | 1 + 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/frontend/package-lock.json b/src/frontend/package-lock.json index 58ceb044a..673f56f10 100644 --- a/src/frontend/package-lock.json +++ b/src/frontend/package-lock.json @@ -3444,7 +3444,7 @@ "version": "16.18.12", "resolved": "https://registry.npmjs.org/@types/node/-/node-16.18.12.tgz", "integrity": "sha512-vzLe5NaNMjIE3mcddFVGlAXN1LEWueUsMsOJWaT6wWMJGyljHAWHznqfnKUQWGzu7TLPrGvWdNAsvQYW+C0xtw==", - "dev": true + "devOptional": true }, "node_modules/@types/parse-json": { "version": "4.0.0", @@ -5504,7 +5504,6 @@ "version": "2.3.2", "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz", "integrity": "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==", - "dev": true, "hasInstallScript": true, "optional": true, "os": [ diff --git a/src/frontend/src/CustomNodes/GenericNode/index.tsx b/src/frontend/src/CustomNodes/GenericNode/index.tsx index fb1ed5f59..cfdc34782 100644 --- a/src/frontend/src/CustomNodes/GenericNode/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/index.tsx @@ -88,8 +88,8 @@ export default function GenericNode({ }} />
- -
{data.type}
+ +
{data.node.display_name}
diff --git a/src/frontend/src/types/api/index.ts b/src/frontend/src/types/api/index.ts index e736d4275..928a088dd 100644 --- a/src/frontend/src/types/api/index.ts +++ b/src/frontend/src/types/api/index.ts @@ -11,6 +11,7 @@ export type APIClassType = { base_classes: Array; description: string; template: APITemplateType; + display_name: string; [key: string]: Array | string | APITemplateType; }; export type TemplateVariableType = {