From 01a289dd9a5cfe5bd5290152424c89a86dbbd57a Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Fri, 8 Sep 2023 14:28:32 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(users.py):=20assign=20the=20?= =?UTF-8?q?hashed=20new=20password=20to=20a=20variable=20before=20updating?= =?UTF-8?q?=20the=20user's=20password=20to=20ensure=20consistency=20?= =?UTF-8?q?=E2=9C=85=20test(test=5Fuser.py):=20add=20test=20to=20verify=20?= =?UTF-8?q?if=20the=20new=20password=20works=20after=20resetting=20it?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/backend/langflow/api/v1/users.py | 4 ++-- tests/test_user.py | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/backend/langflow/api/v1/users.py b/src/backend/langflow/api/v1/users.py index deb350414..81b0c2332 100644 --- a/src/backend/langflow/api/v1/users.py +++ b/src/backend/langflow/api/v1/users.py @@ -121,8 +121,8 @@ def reset_password( if not user: raise HTTPException(status_code=404, detail="User not found") - - user.password = get_password_hash(user_update.password) + new_password = get_password_hash(user_update.password) + user.password = new_password session.commit() session.refresh(user) diff --git a/tests/test_user.py b/tests/test_user.py index 4f2307624..54a713ef1 100644 --- a/tests/test_user.py +++ b/tests/test_user.py @@ -185,6 +185,10 @@ def test_patch_reset_password(client, active_user, logged_in_headers): headers=logged_in_headers, ) assert response.status_code == 200, response.json() + # Now we need to test if the new password works + login_data = {"username": active_user.username, "password": "newpassword"} + response = client.post("/api/v1/login", data=login_data) + assert response.status_code == 200 def test_patch_user_wrong_id(client, active_user, logged_in_headers):