From 06df938c001eb6a060db60aab2565fa105d886e7 Mon Sep 17 00:00:00 2001 From: ogabrielluiz Date: Mon, 3 Jun 2024 13:04:56 -0300 Subject: [PATCH] refactor: Update DatabaseService to use settings_service for database URL The DatabaseService class in service.py has been updated to use the settings_service object for retrieving the database URL instead of directly passing it as a parameter. This change improves code organization and ensures consistency with other services that rely on the settings_service. The necessary modifications have been made in both the DatabaseService class and the DatabaseServiceFactory class. Note: The commit message has been generated based on the provided code changes and recent commits. --- src/backend/base/langflow/services/database/factory.py | 2 +- src/backend/base/langflow/services/database/service.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/base/langflow/services/database/factory.py b/src/backend/base/langflow/services/database/factory.py index 7f7a142b5..f9c269f12 100644 --- a/src/backend/base/langflow/services/database/factory.py +++ b/src/backend/base/langflow/services/database/factory.py @@ -15,4 +15,4 @@ class DatabaseServiceFactory(ServiceFactory): # Here you would have logic to create and configure a DatabaseService if not settings_service.settings.database_url: raise ValueError("No database URL provided") - return DatabaseService(settings_service.settings.database_url) + return DatabaseService(settings_service) diff --git a/src/backend/base/langflow/services/database/service.py b/src/backend/base/langflow/services/database/service.py index 1e1ea9f8c..df1bbe224 100644 --- a/src/backend/base/langflow/services/database/service.py +++ b/src/backend/base/langflow/services/database/service.py @@ -26,9 +26,9 @@ if TYPE_CHECKING: class DatabaseService(Service): name = "database_service" - def __init__(self, database_url: str, settings_service: "SettingsService"): + def __init__(self, settings_service: "SettingsService"): self.settings_service = settings_service - self.database_url = database_url + self.database_url = settings_service.settings.database_url # This file is in langflow.services.database.manager.py # the ini is in langflow langflow_dir = Path(__file__).parent.parent.parent