From 08b6739e1e21082a727472279f1e2d1eeb6e0a63 Mon Sep 17 00:00:00 2001
From: cristhianzl <cristhian.lousa@gmail.com>
Date: Wed, 22 Nov 2023 22:08:04 -0300
Subject: [PATCH] fix(nodeToolbarComponent): add data-testid attribute to more
 options modal for easier testing fix(floatComponent.spec): update element
 locator for sideLlamaCpp to llmsLlamaCpp to match changes in the codebase
 fix(floatComponent.spec): update element locator for editAdvancedIcon to use
 getByTestId for more reliable testing

---
 .../pages/FlowPage/components/nodeToolbarComponent/index.tsx  | 1 +
 src/frontend/tests/end-to-end/floatComponent.spec.ts          | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx
index 0686ffe7c..1fbc07095 100644
--- a/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx
+++ b/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx
@@ -173,6 +173,7 @@ export default function NodeToolbarComponent({
               <SelectTrigger>
                 <div>
                   <div
+                    data-testid="more-options-modal"
                     className={classNames(
                       "relative -ml-px inline-flex h-8 w-[31px] items-center rounded-r-md bg-background text-foreground shadow-md ring-1 ring-inset  ring-ring transition-all duration-500 ease-in-out hover:bg-muted focus:z-10" +
                         (nodeLength == 0
diff --git a/src/frontend/tests/end-to-end/floatComponent.spec.ts b/src/frontend/tests/end-to-end/floatComponent.spec.ts
index 2c200b618..264381f6a 100644
--- a/src/frontend/tests/end-to-end/floatComponent.spec.ts
+++ b/src/frontend/tests/end-to-end/floatComponent.spec.ts
@@ -13,7 +13,7 @@ test("FloatComponent", async ({ page }) => {
   await page.waitForTimeout(2000);
 
   await page
-    .locator('//*[@id="sideLlamaCpp"]')
+    .locator('//*[@id="llmsLlamaCpp"]')
     .dragTo(page.locator('//*[@id="react-flow-id"]'));
   await page.mouse.up();
   await page.mouse.down();
@@ -41,7 +41,7 @@ test("FloatComponent", async ({ page }) => {
       '//*[@id="react-flow-id"]/div[1]/div[1]/div[1]/div/div[2]/div/div/div[1]/div/div[1]/div'
     )
     .click();
-  await page.locator('//*[@id="editAdvancedIcon"]').click();
+  await page.getByTestId("more-options-modal").click();
 
   await page.locator('//*[@id="showcache"]').click();
   expect(await page.locator('//*[@id="showcache"]').isChecked()).toBeTruthy();