jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(parameterComponent): update id and data-testid for textarea component to use the name of the parameter instead of index

Browse source 
fix(EditNodeModal): update id and data-testid for textarea component to use the name of the template parameter instead of index
fix(promptModalComponent.spec): update data-testid for textarea components to use the name of the prompt instead of index
fix(group.spec): update data-testid for textarea component to use a more descriptive name instead of index
fix(saveComponents.spec): update data-testid for textarea component to use a more descriptive name instead of index
This commit is contained in:
cristhianzl 2024-01-18 18:18:18 -03:00
commit 0f0488e59a
5 changed files with 47 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx
View file

@ -400,8 +400,8 @@ export default function ParameterComponent({
disabled={disabled} disabled={disabled}
value={data.node.template[name].value ?? ""} value={data.node.template[name].value ?? ""}
onChange={handleOnNewValue} onChange={handleOnNewValue}
id={"textarea-" + index} id={"textarea-" + data.node.template[name].name}
data-testid={"textarea-" + index} data-testid={"textarea-" + data.node.template[name].name}
/> />
) : ( ) : (
<InputComponent <InputComponent

20
src/frontend/src/modals/EditNodeModal/index.tsx
View file

@ -216,8 +216,16 @@ const EditNodeModal = forwardRef(
) : myData.node.template[templateParam] ) : myData.node.template[templateParam]
.multiline ? ( .multiline ? (
<TextAreaComponent <TextAreaComponent
id={"textarea-edit-" + index} id={
data-testid={"textarea-edit-" + index} "textarea-edit-" +
myData.node.template[templateParam]
.name
}
data-testid={
"textarea-edit-" +
myData.node.template[templateParam]
.name
}
disabled={disabled} disabled={disabled}
editNode={true} editNode={true}
value={ value={
@ -448,9 +456,13 @@ const EditNodeModal = forwardRef(
onChange={(value: string | string[]) => { onChange={(value: string | string[]) => {
handleOnNewValue(value, templateParam); handleOnNewValue(value, templateParam);
}} }}
id={"prompt-area-edit" + index} id={
"prompt-area-edit-" +
myData.node.template[templateParam].name
}
data-testid={ data-testid={
"modal-prompt-input-" + index "modal-prompt-input-" +
myData.node.template[templateParam].name
} }
/> />
</div> </div>

56
src/frontend/tests/end-to-end/promptModalComponent.spec.ts
View file

@ -44,7 +44,7 @@ test("PromptTemplateComponent", async ({ page }) => {
await page.getByTestId("genericModalBtnSave").click(); await page.getByTestId("genericModalBtnSave").click();
await page.getByTestId("div-textarea-5").click(); await page.getByTestId("div-textarea-prompt").click();
await page.getByTestId("text-area-modal").fill("prompt_value_!@#!@#"); await page.getByTestId("text-area-modal").fill("prompt_value_!@#!@#");
value = await page.getByTestId("text-area-modal").inputValue(); value = await page.getByTestId("text-area-modal").inputValue();
@ -55,7 +55,7 @@ test("PromptTemplateComponent", async ({ page }) => {
await page.getByTestId("genericModalBtnSave").click(); await page.getByTestId("genericModalBtnSave").click();
await page.getByTestId("div-textarea-6").click(); await page.getByTestId("div-textarea-prompt1").click();
await page await page
.getByTestId("text-area-modal") .getByTestId("text-area-modal")
.fill("prompt_name_test_123123!@#!@#"); .fill("prompt_name_test_123123!@#!@#");
@ -77,29 +77,31 @@ test("PromptTemplateComponent", async ({ page }) => {
await page.getByTestId("more-options-modal").click(); await page.getByTestId("more-options-modal").click();
await page.getByTestId("edit-button-modal").click(); await page.getByTestId("edit-button-modal").click();
value = await page.locator('//*[@id="textarea-edit-1"]').inputValue(); value = await page.locator('//*[@id="textarea-edit-prompt"]').inputValue();
if (value != "prompt_value_!@#!@#") { if (value != "prompt_value_!@#!@#") {
expect(false).toBeTruthy(); expect(false).toBeTruthy();
} }
value = await page.locator('//*[@id="textarea-edit-2"]').inputValue(); value = await page.locator('//*[@id="textarea-edit-prompt1"]').inputValue();
if (value != "prompt_name_test_123123!@#!@#") { if (value != "prompt_name_test_123123!@#!@#") {
expect(false).toBeTruthy(); expect(false).toBeTruthy();
} }
value = await page.locator('//*[@id="prompt-area-edit0"]').innerText(); value = await page
.locator('//*[@id="prompt-area-edit-template"]')
.innerText();
if (value != "{prompt} example {prompt1}") { if (value != "{prompt} example {prompt1}") {
expect(false).toBeTruthy(); expect(false).toBeTruthy();
} }
await page await page
.locator('//*[@id="textarea-edit-2"]') .locator('//*[@id="textarea-edit-prompt1"]')
.fill("prompt_edit_test_12312312321!@#$"); .fill("prompt_edit_test_12312312321!@#$");
await page await page
.locator('//*[@id="textarea-edit-1"]') .locator('//*[@id="textarea-edit-prompt"]')
.fill("prompt_edit_test_44444444444!@#$"); .fill("prompt_edit_test_44444444444!@#$");
await page.locator('//*[@id="showtemplate"]').click(); await page.locator('//*[@id="showtemplate"]').click();
@ -141,35 +143,29 @@ test("PromptTemplateComponent", async ({ page }) => {
await page.locator('//*[@id="saveChangesBtn"]').click(); await page.locator('//*[@id="saveChangesBtn"]').click();
const plusButtonLocator = page.locator('//*[@id="textarea-8"]'); await page.getByTestId("more-options-modal").click();
const elementCount = await plusButtonLocator.count(); await page.getByTestId("edit-button-modal").click();
if (elementCount === 0) {
expect(true).toBeTruthy();
await page.getByTestId("more-options-modal").click(); await page.locator('//*[@id="showprompt1"]').click();
await page.getByTestId("edit-button-modal").click(); expect(await page.locator('//*[@id="showprompt1"]').isChecked()).toBeTruthy();
await page.locator('//*[@id="showprompt1"]').click(); value = await page.locator('//*[@id="textarea-edit-prompt"]').inputValue();
expect(
await page.locator('//*[@id="showprompt1"]').isChecked()
).toBeTruthy();
value = await page.locator('//*[@id="textarea-edit-1"]').inputValue(); if (value != "prompt_edit_test_44444444444!@#$") {
expect(false).toBeTruthy();
}
if (value != "prompt_edit_test_44444444444!@#$") { value = await page.locator('//*[@id="textarea-edit-prompt1"]').inputValue();
expect(false).toBeTruthy();
}
value = await page.locator('//*[@id="textarea-edit-2"]').inputValue(); if (value != "prompt_edit_test_12312312321!@#$") {
expect(false).toBeTruthy();
}
if (value != "prompt_edit_test_12312312321!@#$") { value = await page
expect(false).toBeTruthy(); .locator('//*[@id="prompt-area-edit-template"]')
} .innerText();
value = await page.locator('//*[@id="prompt-area-edit0"]').innerText(); if (value != "{prompt} example {prompt1}") {
expect(false).toBeTruthy();
if (value != "{prompt} example {prompt1}") {
expect(false).toBeTruthy();
}
} }
}); });

2
src/frontend/tests/onlyFront/group.spec.ts
View file

@ -67,7 +67,7 @@ test.describe("group node test", () => {
await page.getByRole("button", { name: "Group" }).click(); await page.getByRole("button", { name: "Group" }).click();
const textArea = page.getByTestId("div-textarea-2"); const textArea = page.getByTestId("div-textarea-description");
const elementCountText = await textArea.count(); const elementCountText = await textArea.count();
if (elementCountText > 0) { if (elementCountText > 0) {
expect(true).toBeTruthy(); expect(true).toBeTruthy();

4
src/frontend/tests/onlyFront/saveComponents.spec.ts
View file

@ -74,7 +74,7 @@ test.describe("save component tests", () => {
await page.getByRole("button", { name: "Group" }).click(); await page.getByRole("button", { name: "Group" }).click();
let textArea = page.getByTestId("div-textarea-2"); let textArea = page.getByTestId("div-textarea-description");
let elementCountText = await textArea.count(); let elementCountText = await textArea.count();
if (elementCountText > 0) { if (elementCountText > 0) {
expect(true).toBeTruthy(); expect(true).toBeTruthy();
@ -102,7 +102,7 @@ test.describe("save component tests", () => {
await page.mouse.up(); await page.mouse.up();
await page.mouse.down(); await page.mouse.down();
textArea = page.getByTestId("div-textarea-2"); textArea = page.getByTestId("div-textarea-description");
elementCountText = await textArea.count(); elementCountText = await textArea.count();
if (elementCountText > 0) { if (elementCountText > 0) {
expect(true).toBeTruthy(); expect(true).toBeTruthy();