feat: change params for models (#6992)

* feat: change advanced params for models

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* fix: ruff erros

* remove Redundant component

* refactor: streamline freeze-path test by removing redundant slider interactions and updating model selection

- Removed unnecessary wait for the default slider display value.
- Updated model selection to use 'gpt-4o-mini-0-option' for varied output in tests.

* [autofix.ci] apply automated fixes

* test: update slider component test to reflect new parameter values and structure

- Modified the test to replace a multiline string with updated values for the slider component.
- Ensured that the new code differs from the original to validate changes.
- Adjusted the test to fill the textarea with the new code after modification.

* ✅ (intComponent.spec.ts): update test assertions to match expected behavior for IntComponent regarding checkbox states

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Edwin Jose <edwin.jose@datastax.com>
Co-authored-by: italojohnny <italojohnnydosanjos@gmail.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Co-authored-by: cristhianzl <cristhian.lousa@gmail.com>
This commit is contained in:
Rodrigo Nader 2025-03-17 15:17:35 -03:00 • committed by GitHub
commit 100c4b8eba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
36 changed files with 140 additions and 111 deletions

View file

@ -35,14 +35,7 @@ test(
await page.getByTestId("dropdown_str_model_name").click();
await page.getByTestId("gpt-4o-1-option").click();
await page.waitForSelector('[data-testid="default_slider_display_value"]', {
timeout: 1000,
});
await page.getByTestId("fit_view").click();
await page
.getByTestId("default_slider_display_value")
.click({ force: true });
await page.waitForSelector('[data-testid="button_run_chat output"]', {
timeout: 1000,
@ -68,11 +61,9 @@ test(
await page.getByText("Close").last().click();
await page.waitForSelector('[data-testid="default_slider_display_value"]', {
timeout: 1000,
});
await moveSlider(page, "right", false);
// Change model to force different output
await page.getByTestId("dropdown_str_model_name").click();
await page.getByTestId("gpt-4o-mini-0-option").click();
await page.waitForSelector('[data-testid="button_run_chat output"]', {
timeout: 1000,

View file

@ -90,7 +90,7 @@ test("IntComponent", { tag: ["@release", "@workspace"] }, async ({ page }) => {
await page.locator('//*[@id="showtemperature"]').click();
expect(
await page.locator('//*[@id="showtemperature"]').isChecked(),
).toBeFalsy();
).toBeTruthy();
await page.locator('//*[@id="showmodel_kwargs"]').click();
expect(
@ -110,7 +110,7 @@ test("IntComponent", { tag: ["@release", "@workspace"] }, async ({ page }) => {
await page.locator('//*[@id="showtemperature"]').click();
expect(
await page.locator('//*[@id="showtemperature"]').isChecked(),
).toBeTruthy();
).toBeFalsy();
await page.locator('//*[@id="showmodel_kwargs"]').click();
expect(
@ -130,7 +130,7 @@ test("IntComponent", { tag: ["@release", "@workspace"] }, async ({ page }) => {
await page.locator('//*[@id="showtemperature"]').click();
expect(
await page.locator('//*[@id="showtemperature"]').isChecked(),
).toBeFalsy();
).toBeTruthy();
await page.getByText("Close").last().click();

View file

@ -35,15 +35,31 @@ test(
let cleanCode = await extractAndCleanCode(page);
// Replace the import statement
cleanCode = cleanCode.replace(
'name="temperature", display_name="Temperature", value=0.1, range_spec=RangeSpec(min=0, max=1, step=0.01)',
'name="temperature", display_name="Temperature", value=0.2, range_spec=RangeSpec(min=3, max=30, step=1), min_label="test", max_label="test2", min_label_icon="pencil-ruler", max_label_icon="palette", slider_buttons=False, slider_buttons_options=[], slider_input=False,',
// Replace the multiline string in the code
const newCode = cleanCode.replace(
`name="temperature",
display_name="Temperature",
value=0.1,
range_spec=RangeSpec(min=0, max=1, step=0.01),
advanced=True,`,
`name="temperature",
display_name="Temperature",
value=0.2,
range_spec=RangeSpec(min=3, max=30, step=1),
min_label="test",
max_label="test2",
min_label_icon="pencil-ruler",
max_label_icon="palette",
slider_buttons=False,
slider_buttons_options=[],
slider_input=False,
advanced=False,`,
);
// make sure codes are different
expect(cleanCode).not.toEqual(newCode);
await page.locator("textarea").last().press(`ControlOrMeta+a`);
await page.keyboard.press("Backspace");
await page.locator("textarea").last().fill(cleanCode);
await page.locator("textarea").last().fill(newCode);
await page.locator('//*[@id="checkAndSaveBtn"]').click();
await page.getByTestId("fit_view").click();