From 120c4687eeff9d543990978840a19c97a1bcdcaf Mon Sep 17 00:00:00 2001 From: cristhianzl Date: Mon, 1 Apr 2024 21:28:06 -0300 Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20(playwright.config.ts):=20decrease?= =?UTF-8?q?=20the=20number=20of=20workers=20from=203=20to=202=20to=20impro?= =?UTF-8?q?ve=20test=20performance=20=F0=9F=90=9B=20(chat=5Fio.spec.ts):?= =?UTF-8?q?=20remove=20unnecessary=20wait=20and=20fix=20typo=20in=20test?= =?UTF-8?q?=20name=20=F0=9F=90=9B=20(codeAreaModalComponent.spec.ts):=20re?= =?UTF-8?q?move=20unnecessary=20click=20action=20=F0=9F=90=9B=20(curl=5Fap?= =?UTF-8?q?i=5Fgeneration.spec.ts):=20fix=20the=20URL=20in=20page.goto()?= =?UTF-8?q?=20to=20include=20the=20protocol=20=F0=9F=90=9B=20(dropdownComp?= =?UTF-8?q?onent.spec.ts):=20remove=20unnecessary=20click=20actions=20?= =?UTF-8?q?=F0=9F=90=9B=20(inputListComponent.spec.ts):=20remove=20duplica?= =?UTF-8?q?te=20click=20action=20=F0=9F=90=9B=20(python=5Fapi=5Fgeneration?= =?UTF-8?q?.spec.ts):=20fix=20the=20test=20name=20in=20getByRole()=20funct?= =?UTF-8?q?ion=20=F0=9F=90=9B=20(tweaks=5Ftest.spec.ts):=20fix=20the=20tes?= =?UTF-8?q?t=20name=20in=20getByRole()=20function?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/playwright.config.ts | 2 +- src/frontend/tests/end-to-end/chat_io.spec.ts | 4 ++- .../end-to-end/codeAreaModalComponent.spec.ts | 2 -- .../end-to-end/curl_api_generation.spec.ts | 4 +-- .../end-to-end/dropdownComponent.spec.ts | 26 ------------------- .../end-to-end/inputListComponent.spec.ts | 1 + .../end-to-end/python_api_generation.spec.ts | 2 +- .../tests/end-to-end/tweaks_test.spec.ts | 2 +- 8 files changed, 9 insertions(+), 34 deletions(-) diff --git a/src/frontend/playwright.config.ts b/src/frontend/playwright.config.ts index 649c42390..97f3e2c9e 100644 --- a/src/frontend/playwright.config.ts +++ b/src/frontend/playwright.config.ts @@ -18,7 +18,7 @@ export default defineConfig({ /* Retry on CI only */ retries: process.env.CI ? 2 : 0, /* Opt out of parallel tests on CI. */ - workers: 3, + workers: 2, /* Reporter to use. See https://playwright.dev/docs/test-reporters */ timeout: 120 * 1000, // reporter: [ diff --git a/src/frontend/tests/end-to-end/chat_io.spec.ts b/src/frontend/tests/end-to-end/chat_io.spec.ts index 2e85bc11d..339428e57 100644 --- a/src/frontend/tests/end-to-end/chat_io.spec.ts +++ b/src/frontend/tests/end-to-end/chat_io.spec.ts @@ -13,8 +13,10 @@ test("chat_io_teste", async ({ page }) => { "utf-8" ); + await page.waitForTimeout(3000); + + await page.locator('//*[@id="new-project-btn"]').click(); await page.locator('//*[@id="new-project-btn"]').click(); - await page.waitForTimeout(2000); await page.getByTestId("blank-flow").click(); await page.waitForTimeout(2000); diff --git a/src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts b/src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts index 299b94d95..13ed9fe74 100644 --- a/src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts +++ b/src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts @@ -15,8 +15,6 @@ test("CodeAreaModalComponent", async ({ page }) => { await page.waitForTimeout(1000); - await page.getByTestId("extended-disclosure").click(); - await page .getByTestId("toolsPythonFunctionTool") .dragTo(page.locator('//*[@id="react-flow-id"]')); diff --git a/src/frontend/tests/end-to-end/curl_api_generation.spec.ts b/src/frontend/tests/end-to-end/curl_api_generation.spec.ts index b725badb1..4525fa698 100644 --- a/src/frontend/tests/end-to-end/curl_api_generation.spec.ts +++ b/src/frontend/tests/end-to-end/curl_api_generation.spec.ts @@ -1,10 +1,10 @@ import { expect, test } from "@playwright/test"; test("curl_api_generation", async ({ page, context }) => { - await page.goto("/"); + await page.goto("http:localhost:3000/"); await page.locator('//*[@id="new-project-btn"]').click(); await context.grantPermissions(["clipboard-read", "clipboard-write"]); - await page.getByRole("heading", { name: "Data Ingestion" }).click(); + await page.getByRole("heading", { name: "Basic Prompting" }).click(); await page.waitForTimeout(2000); await page.getByText("API", { exact: true }).click(); await page.getByRole("tab", { name: "cURL" }).click(); diff --git a/src/frontend/tests/end-to-end/dropdownComponent.spec.ts b/src/frontend/tests/end-to-end/dropdownComponent.spec.ts index 8eab5882a..a31ceae44 100644 --- a/src/frontend/tests/end-to-end/dropdownComponent.spec.ts +++ b/src/frontend/tests/end-to-end/dropdownComponent.spec.ts @@ -89,16 +89,6 @@ test("dropDownComponent", async ({ page }) => { await page.locator('//*[@id="showendpoint_url"]').isChecked() ).toBeTruthy(); - await page.locator('//*[@id="showmodel_kwargs"]').click(); - expect( - await page.locator('//*[@id="showmodel_kwargs"]').isChecked() - ).toBeFalsy(); - - await page.locator('//*[@id="showmodel_kwargs"]').click(); - expect( - await page.locator('//*[@id="showmodel_kwargs"]').isChecked() - ).toBeTruthy(); - await page.locator('//*[@id="showregion_name"]').click(); expect( await page.locator('//*[@id="showregion_name"]').isChecked() @@ -145,16 +135,6 @@ test("dropDownComponent", async ({ page }) => { await page.locator('//*[@id="showendpoint_url"]').isChecked() ).toBeTruthy(); - await page.locator('//*[@id="showmodel_kwargs"]').click(); - expect( - await page.locator('//*[@id="showmodel_kwargs"]').isChecked() - ).toBeFalsy(); - - await page.locator('//*[@id="showmodel_kwargs"]').click(); - expect( - await page.locator('//*[@id="showmodel_kwargs"]').isChecked() - ).toBeTruthy(); - await page.locator('//*[@id="showregion_name"]').click(); expect( await page.locator('//*[@id="showregion_name"]').isChecked() @@ -165,12 +145,6 @@ test("dropDownComponent", async ({ page }) => { await page.locator('//*[@id="showregion_name"]').isChecked() ).toBeTruthy(); - await page.locator('//*[@id="showstream"]').click(); - expect(await page.locator('//*[@id="showstream"]').isChecked()).toBeFalsy(); - - await page.locator('//*[@id="showstream"]').click(); - expect(await page.locator('//*[@id="showstream"]').isChecked()).toBeTruthy(); - // showmodel_id await page.locator('//*[@id="showmodel_id"]').click(); expect(await page.locator('//*[@id="showmodel_id"]').isChecked()).toBeFalsy(); diff --git a/src/frontend/tests/end-to-end/inputListComponent.spec.ts b/src/frontend/tests/end-to-end/inputListComponent.spec.ts index d23b071e5..3ed170af2 100644 --- a/src/frontend/tests/end-to-end/inputListComponent.spec.ts +++ b/src/frontend/tests/end-to-end/inputListComponent.spec.ts @@ -6,6 +6,7 @@ test("InputListComponent", async ({ page }) => { await page.locator('//*[@id="new-project-btn"]').click(); await page.waitForTimeout(1000); + await page.locator('//*[@id="new-project-btn"]').click(); await page.getByTestId("blank-flow").click(); await page.waitForTimeout(1000); diff --git a/src/frontend/tests/end-to-end/python_api_generation.spec.ts b/src/frontend/tests/end-to-end/python_api_generation.spec.ts index 2d7a6af0d..6c70ebbb1 100644 --- a/src/frontend/tests/end-to-end/python_api_generation.spec.ts +++ b/src/frontend/tests/end-to-end/python_api_generation.spec.ts @@ -4,7 +4,7 @@ test("python_api_generation", async ({ page, context }) => { await page.goto("/"); await page.locator('//*[@id="new-project-btn"]').click(); await context.grantPermissions(["clipboard-read", "clipboard-write"]); - await page.getByRole("heading", { name: "Data Ingestion" }).click(); + await page.getByRole("heading", { name: "Basic Prompting" }).click(); await page.waitForTimeout(2000); await page.getByText("API", { exact: true }).click(); await page.getByRole("tab", { name: "Python API" }).click(); diff --git a/src/frontend/tests/end-to-end/tweaks_test.spec.ts b/src/frontend/tests/end-to-end/tweaks_test.spec.ts index acfe6f1cb..183099b46 100644 --- a/src/frontend/tests/end-to-end/tweaks_test.spec.ts +++ b/src/frontend/tests/end-to-end/tweaks_test.spec.ts @@ -4,7 +4,7 @@ test("curl_api_generation", async ({ page, context }) => { await page.goto("/"); await page.locator('//*[@id="new-project-btn"]').click(); await context.grantPermissions(["clipboard-read", "clipboard-write"]); - await page.getByRole("heading", { name: "Data Ingestion" }).click(); + await page.getByRole("heading", { name: "Basic Prompting" }).click(); await page.waitForTimeout(2000); await page.getByText("API", { exact: true }).click(); await page.getByRole("tab", { name: "cURL" }).click();