refactor: Improve wait times and visibility checks in auto-save-off tests (#5044)

* refactor: Improve wait times and visibility checks in auto-save-off tests
This commit is contained in:
anovazzi1 2024-12-05 14:50:34 -03:00 • committed by GitHub
commit 18c423b2f1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -42,7 +42,9 @@ test(
while (modalCount === 0) { while (modalCount === 0) {
await page.getByText("New Flow", { exact: true }).click(); await page.getByText("New Flow", { exact: true }).click();
await page.waitForTimeout(3000); await page.waitForSelector('[data-testid="modal-title"]', {
timeout: 3000,
});
modalCount = await page.getByTestId("modal-title")?.count(); modalCount = await page.getByTestId("modal-title")?.count();
} }
@ -55,7 +57,9 @@ test(
await page.getByTestId("sidebar-search-input").click(); await page.getByTestId("sidebar-search-input").click();
await page.getByTestId("sidebar-search-input").fill("NVIDIA"); await page.getByTestId("sidebar-search-input").fill("NVIDIA");
await page.waitForTimeout(1000); await page.waitForSelector('[data-testid="modelsNVIDIA"]', {
timeout: 3000,
});
await page await page
.getByTestId("modelsNVIDIA") .getByTestId("modelsNVIDIA")
@ -76,12 +80,12 @@ test(
.first() .first()
.hover() .hover()
.then(async () => { .then(async () => {
await page.waitForTimeout(1000); await expect(
await page.getByText("Auto-saving is disabled").nth(0).isVisible(); page.getByText("Auto-saving is disabled").nth(0),
await page ).toBeVisible({ timeout: 5000 });
.getByText("Enable auto-saving to avoid losing progress.") await expect(
.nth(0) page.getByText("Enable auto-saving to avoid losing progress.").nth(0),
.isVisible(); ).toBeVisible({ timeout: 3000 });
}); });
expect(await page.getByTestId("save-flow-button").isEnabled()).toBeTruthy(); expect(await page.getByTestId("save-flow-button").isEnabled()).toBeTruthy();
@ -93,11 +97,9 @@ test(
await page.getByTestId("icon-ChevronLeft").last().click(); await page.getByTestId("icon-ChevronLeft").last().click();
expect( await expect(
await page page.getByText("Unsaved changes will be permanently lost."),
.getByText("Unsaved changes will be permanently lost.") ).toBeVisible();
.isVisible(),
).toBeTruthy();
await page.getByText("Exit Anyway", { exact: true }).click(); await page.getByText("Exit Anyway", { exact: true }).click();
@ -112,7 +114,9 @@ test(
await page.getByTestId("sidebar-search-input").click(); await page.getByTestId("sidebar-search-input").click();
await page.getByTestId("sidebar-search-input").fill("NVIDIA"); await page.getByTestId("sidebar-search-input").fill("NVIDIA");
await page.waitForTimeout(1000); await page.waitForSelector('[data-testid="modelsNVIDIA"]', {
timeout: 3000,
});
await page await page
.getByTestId("modelsNVIDIA") .getByTestId("modelsNVIDIA")
@ -137,14 +141,16 @@ test(
timeout: 5000, timeout: 5000,
}); });
await page.waitForTimeout(5000); await expect(page.getByTestId("title-NVIDIA")).toBeVisible({
timeout: 5000,
expect(await page.getByTestId("title-NVIDIA").isVisible()).toBeTruthy(); });
await page.getByTestId("sidebar-search-input").click(); await page.getByTestId("sidebar-search-input").click();
await page.getByTestId("sidebar-search-input").fill("NVIDIA"); await page.getByTestId("sidebar-search-input").fill("NVIDIA");
await page.waitForTimeout(1000); await page.waitForSelector('[data-testid="modelsNVIDIA"]', {
timeout: 3000,
});
await page await page
.getByTestId("modelsNVIDIA") .getByTestId("modelsNVIDIA")
@ -182,7 +188,9 @@ test(
timeout: 5000, timeout: 5000,
}); });
await page.waitForTimeout(5000); await expect(page.getByTestId("title-NVIDIA").first()).toBeVisible({
timeout: 5000,
});
const nvidiaNumber = await page.getByTestId("title-NVIDIA").count(); const nvidiaNumber = await page.getByTestId("title-NVIDIA").count();
expect(nvidiaNumber).toBe(2); expect(nvidiaNumber).toBe(2);