refactor(parameterComponent): change setTemplate to setNodeClass to improve semantics and fix bug

refactor(codeAreaComponent): change template to nodeClass and setTemplate to setNodeClass to improve semantics
refactor(API): change UpdateTemplate function parameter from template to nodeClass to improve semantics
refactor(codeAreaModal): change template to nodeClass and setTemplate to setNodeClass to improve semantics and fix bug
refactor(types): add APIClassType to import and change APITemplateType to import in relevant files to improve semantics
This commit is contained in:
anovazzi1 2023-06-22 18:21:41 -03:00
commit 19be2e8178
5 changed files with 22 additions and 21 deletions

View file

@ -227,8 +227,8 @@ export default function ParameterComponent({
</div>
) : left === true && type === "code" ? (
<CodeAreaComponent
setTemplate={(template)=>{data.node.template = template}}
template={data.node.template}
setNodeClass={(nodeClass)=>{data.node = nodeClass}}
nodeClass={data.node}
disabled={disabled}
value={data.node.template[name].value ?? ""}
onChange={handleOnNewValue}

View file

@ -11,8 +11,8 @@ export default function CodeAreaComponent({
onChange,
disabled,
editNode = false,
template,
setTemplate,
nodeClass,
setNodeClass,
}: CodeAreaComponentType) {
const [myValue, setMyValue] = useState(value);
const { openPopUp } = useContext(PopUpContext);
@ -39,8 +39,8 @@ export default function CodeAreaComponent({
openPopUp(
<CodeAreaModal
value={myValue}
template={template}
setTemplate={setTemplate}
nodeClass={nodeClass}
setNodeClass={setNodeClass}
setValue={(t: string) => {
setMyValue(t);
onChange(t);
@ -63,9 +63,9 @@ export default function CodeAreaComponent({
onClick={() => {
openPopUp(
<CodeAreaModal
setTemplate={setTemplate}
setNodeClass={setNodeClass}
value={myValue}
template={template}
nodeClass={nodeClass}
setValue={(t: string) => {
setMyValue(t);
onChange(t);

View file

@ -5,6 +5,7 @@ import {
InitTypeAPI,
TemplateVariableType,
APITemplateType,
APIClassType,
} from "./../../types/api/index";
import { APIObjectType, sendAllProps } from "../../types/api/index";
import axios, { AxiosResponse } from "axios";
@ -322,6 +323,6 @@ export async function postBuildInit(
return await axios.post(`/api/v1/build/init`, flow);
}
export async function UpdateTemplate(type:string, template:APITemplateType):Promise<AxiosResponse<{template:APITemplateType}>>{
export async function UpdateTemplate(type:string, nodeClass:APIClassType):Promise<AxiosResponse<APIClassType>>{
return await axios.get(`/dynamic_node`);
}

View file

@ -23,18 +23,18 @@ import {
import { Button } from "../../components/ui/button";
import { CODE_PROMPT_DIALOG_SUBTITLE } from "../../constants";
import Loading from "../../components/ui/loading";
import { APITemplateType } from "../../types/api";
import { APIClassType, APITemplateType } from "../../types/api";
export default function CodeAreaModal({
value,
setValue,
template,
setTemplate
nodeClass,
setNodeClass
}: {
setValue: (value: string) => void;
value: string;
template: APITemplateType,
setTemplate: (template: APITemplateType) => void;
nodeClass: APIClassType,
setNodeClass: (Class: APIClassType) => void;
}) {
const [open, setOpen] = useState(true);
const [code, setCode] = useState(value);
@ -93,11 +93,11 @@ export default function CodeAreaModal({
})
}
);
UpdateTemplate('code',template).then((apiReturn) => {
UpdateTemplate('code',nodeClass).then((apiReturn) => {
const data = apiReturn.data;
if (data.template) {
console.log('updated')
setTemplate(data.template);
if (data) {
console.log(data)
setNodeClass(data);
setModalOpen(false);
}
})

View file

@ -1,7 +1,7 @@
import { ForwardRefExoticComponent, ReactElement, ReactNode } from "react";
import { NodeDataType } from "../flow/index";
import { typesContextType } from "../typesContext";
import { APITemplateType } from "../api";
import { APIClassType, APITemplateType } from "../api";
export type InputComponentType = {
value: string;
disabled?: boolean;
@ -56,8 +56,8 @@ export type CodeAreaComponentType = {
onChange: (value: string[] | string) => void;
value: string;
editNode?: boolean;
template: APITemplateType;
setTemplate: (value: APITemplateType) => void;
nodeClass: APIClassType;
setNodeClass: (value: APIClassType) => void;
};
export type FileComponentType = {