jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: Avoid unnecessary field resets in the API Request component (#7544)

Browse source 
* Add a logic to skip field reset if curl is not used

* Remove the else clause to avoid setting all other fields to advanced

* Fix return type

* Add a logic to avoid setting a field to advanced when use_curl is not defined

* Refactor else logic of _update_method_fields and _update_curl_mode

* Rollback _update_method_fields changes

* Return the current build config instead of an empty dict

---------

Co-authored-by: Edwin Jose <edwin.jose@datastax.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
This commit is contained in:
Thiago Araujo 2025-05-14 14:27:13 -03:00 • committed by GitHub
commit 1a4adaceb8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/backend/base/langflow/components/data/api_request.py
View file

@ -287,6 +287,10 @@ class APIRequestComponent(Component):
# if we remove field value from validation, this gets validated every time # if we remove field value from validation, this gets validated every time
build_config = self._update_curl_mode(build_config, use_curl=field_value) build_config = self._update_curl_mode(build_config, use_curl=field_value)
# If curl is not used, we don't need to reset the fields
if not self.use_curl:
return build_config
# Fields that should not be reset # Fields that should not be reset
preserve_fields = {"timeout", "follow_redirects", "save_to_file", "include_httpx_metadata", "use_curl"} preserve_fields = {"timeout", "follow_redirects", "save_to_file", "include_httpx_metadata", "use_curl"}
@ -336,7 +340,7 @@ class APIRequestComponent(Component):
elif field_name in {"body", "headers"}: elif field_name in {"body", "headers"}:
field_config["advanced"] = True # Always keep body and headers in advanced when use_curl is False field_config["advanced"] = True # Always keep body and headers in advanced when use_curl is False
else: else:
field_config["advanced"] = use_curl field_config["advanced"] = use_curl or field_config.get("advanced")
else: else:
self.log(f"Expected dict for build_config[{field_name}], got {type(field_config).__name__}") self.log(f"Expected dict for build_config[{field_name}], got {type(field_config).__name__}")
@ -374,8 +378,6 @@ class APIRequestComponent(Component):
field_config["advanced"] = method not in {"POST", "PUT", "PATCH"} field_config["advanced"] = method not in {"POST", "PUT", "PATCH"}
elif field_name in always_advanced_fields: elif field_name in always_advanced_fields:
field_config["advanced"] = True field_config["advanced"] = True
else:
field_config["advanced"] = True
else: else:
self.log(f"Expected dict for build_config[{field_name}], got {type(field_config).__name__}") self.log(f"Expected dict for build_config[{field_name}], got {type(field_config).__name__}")