jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: improve ref naming causing fallback error on icons + regression test (#6989)

Browse source 
* ♻️ (index.tsx): remove unused ShortUniqueId import and uid variable to clean up the code
💡 (index.tsx): refactor useEffect dependency array to only include necessary dependencies for better performance and readability
♻️ (index.tsx): refactor PopoverContent component to use notificationRef instead of inline ref assignment for better code organization

* ✨ (loading.tsx): add data-testid attribute to loading icon for easier testing and identification in the UI
✅ (general-bugs-icons-fallback.spec.ts): add test to ensure that loading icon fallback is displayed correctly when the icon is not found
This commit is contained in:
Cristhian Zanforlin Lousa 2025-03-10 18:04:31 -03:00 • committed by GitHub
commit 203ca36d5a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 29 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/frontend/tests/extended/regression/general-bugs-icons-fallback.spec.ts Normal file
View file

@ -0,0 +1,24 @@
import { expect, test } from "@playwright/test";
import { awaitBootstrapTest } from "../../utils/await-bootstrap-test";
import { extractAndCleanCode } from "../../utils/extract-and-clean-code";
test(
"user must be able to see icons fallback if the icon is not found",
{ tag: ["@release", "@components"] },
async ({ page }) => {
await awaitBootstrapTest(page);
await page.getByTestId("blank-flow").click();
await page.waitForSelector('[data-testid="fit_view"]', {
timeout: 100000,
});
await page.getByTestId("disclosure-data").click();
await page.waitForTimeout(500);
await page.getByTestId("disclosure-processing").click();
await page.waitForTimeout(500);
const loadingIcons = await page.getByTestId("loading-icon").count();
expect(loadingIcons).toBe(0);
},
);