From 2625e320c9f95606d0ae28e8f877250881c1acff Mon Sep 17 00:00:00 2001
From: anovazzi1 <otavio2204@gmail.com>
Date: Tue, 30 Apr 2024 12:54:59 -0300
Subject: [PATCH] Refactored GlobalVariablesPage component to use useEffect
 hook for populating rows dynamically

---
 .../pages/GlobalVariablesPage/index.tsx       | 61 +++++--------------
 1 file changed, 14 insertions(+), 47 deletions(-)

diff --git a/src/frontend/src/pages/SettingsPage/pages/GlobalVariablesPage/index.tsx b/src/frontend/src/pages/SettingsPage/pages/GlobalVariablesPage/index.tsx
index ff674e5e6..d0d786985 100644
--- a/src/frontend/src/pages/SettingsPage/pages/GlobalVariablesPage/index.tsx
+++ b/src/frontend/src/pages/SettingsPage/pages/GlobalVariablesPage/index.tsx
@@ -12,8 +12,6 @@ import { useGlobalVariablesStore } from "../../../../stores/globalVariables";
 import { cn } from "../../../../utils/utils";
 
 export default function GlobalVariablesPage() {
-  const rows: Array<{ type: string | undefined; id: string; name: string }> =
-    [];
   const globalVariablesEntries = useGlobalVariablesStore(
     (state) => state.globalVariablesEntries
   );
@@ -23,14 +21,6 @@ export default function GlobalVariablesPage() {
   const globalVariables = useGlobalVariablesStore(
     (state) => state.globalVariables
   );
-  globalVariablesEntries.forEach((e) => {
-    const globalVariableObj = globalVariables[e];
-    rows.push({
-      type: globalVariableObj.type,
-      id: globalVariableObj.id,
-      name: e,
-    });
-  });
 
   const BadgeRenderer = (props) => {
     return props.value !== "" ? (
@@ -43,8 +33,18 @@ export default function GlobalVariablesPage() {
       <div></div>
     );
   };
+  const [rowData, setRowData] = useState<{ type: string | undefined; id: string; name: string; }[]>();
 
   useEffect(() => {
+    const rows:Array<{type: string | undefined; id: string; name: string}> = [];
+    globalVariablesEntries.forEach((e) => {
+      const globalVariableObj = globalVariables[e];
+      rows.push({
+        type: globalVariableObj.type,
+        id: globalVariableObj.id,
+        name: e,
+      });
+    });
     setRowData(rows);
   }, [globalVariables]);
 
@@ -70,57 +70,24 @@ export default function GlobalVariablesPage() {
       cellRenderer: BadgeRenderer,
       cellEditor: DropdownEditor,
       cellEditorParams: {
-        options: ["Prompt", "Credential"],
+        options: ["Generic", "Credential"],
       },
       flex: 1,
-      editable: true,
+      editable: false,
     },
     {
       field: "value",
       cellEditor: "agLargeTextCellEditor",
-      cellEditorPopup: true,
       flex: 2,
-      editable: true,
+      editable: false,
     },
     {
       headerName: "Apply To Fields",
       field: "defaultFields",
       flex: 1,
-      editable: true,
+      editable: false,
     },
-  ]);
 
-  const [rowData, setRowData] = useState([
-    {
-      name: "OpenAI Key",
-      type: "Credential",
-      value: "apijpioj09u302j0982ejf",
-      defaultFields: "Open AI API Key",
-    },
-    {
-      name: "Prompt",
-      type: "Prompt",
-      value: `Answer user's questions based on the document below:
-
-    ---
-    
-    {Document}
-    
-    ---
-    
-    Question:
-    {Question}
-    
-    Answer:
-    `,
-      defaultFields: ["Prompt"],
-    },
-    {
-      name: "Azure Key",
-      type: "Credential",
-      value: "awowkdenvoaimojndofunoweoij0293u0n2e08n23",
-      defaultFields: ["Azure API Key"],
-    },
   ]);
 
   const [selectedRows, setSelectedRows] = useState<string[]>([]);