From 27bc4c549862db2355495d812111e872254861f2 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Mon, 23 Oct 2023 22:47:41 -0300 Subject: [PATCH] fix(EditNodeModal): only reset data and call onClose when modalOpen is true to prevent unnecessary side effects --- src/frontend/src/modals/EditNodeModal/index.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/frontend/src/modals/EditNodeModal/index.tsx b/src/frontend/src/modals/EditNodeModal/index.tsx index 8d49b23b3..af70d6b0e 100644 --- a/src/frontend/src/modals/EditNodeModal/index.tsx +++ b/src/frontend/src/modals/EditNodeModal/index.tsx @@ -89,8 +89,10 @@ const EditNodeModal = forwardRef( }; useEffect(() => { - myData.current = data; // reset data to what it is on node when opening modal - onClose!(modalOpen); + if (modalOpen) { + myData.current = data; // reset data to what it is on node when opening modal + onClose!(modalOpen); + } }, [modalOpen]); const [errorDuplicateKey, setErrorDuplicateKey] = useState(false);