From 2bd16f5f860e4e5c7f9bec6f52f4ef1b363ff002 Mon Sep 17 00:00:00 2001 From: Eric Pinzur <2641606+epinzur@users.noreply.github.com> Date: Thu, 31 Jul 2025 16:32:47 +0200 Subject: [PATCH] chore: continue cross-product debug (#9269) chore:continue cross-product debug --- .github/workflows/cross-platform-test.yml | 47 ++++++++++------------- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/.github/workflows/cross-platform-test.yml b/.github/workflows/cross-platform-test.yml index aa1525dbd..df7501e91 100644 --- a/.github/workflows/cross-platform-test.yml +++ b/.github/workflows/cross-platform-test.yml @@ -20,24 +20,10 @@ on: type: string jobs: - debug-github-context: - name: Debug GitHub Context - runs-on: ubuntu-latest - steps: - - name: Debug all GitHub context - run: | - echo "Event name: ${{ github.event_name }}" - echo "Workflow: ${{ github.workflow }}" - echo "Workflow ref: ${{ github.workflow_ref }}" - echo "Actor: ${{ github.actor }}" - echo "Triggering actor: ${{ github.triggering_actor }}" - echo "Event path: ${{ github.event_path }}" - echo "Repository: ${{ github.repository }}" - build-if-needed: name: Build Packages (if no artifacts provided) runs-on: ubuntu-latest - if: inputs.langflow-version == '' && github.workflow == 'Cross-Platform Installation Test' + if: inputs.langflow-version == '' && contains(github.workflow_ref, 'cross-platform-test.yml') outputs: base-artifact-name: ${{ steps.set-names.outputs.base-artifact-name }} main-artifact-name: ${{ steps.set-names.outputs.main-artifact-name }} @@ -379,18 +365,11 @@ jobs: steps: - name: Check test results run: | - if [ "${{ needs.test-installation.result }}" != "success" ]; then - if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then - if [ -n "${{ inputs.langflow-version }}" ]; then - echo "❌ PyPI installation tests failed" - else - echo "❌ Source build and installation tests failed" - fi - else - echo "❌ Cross-platform tests failed - PyPI upload blocked" - fi - exit 1 - else + result="${{ needs.test-installation.result }}" + echo "Test installation result: $result" + + # Log appropriate message but don't fail for continue-on-error jobs + if [ "$result" = "success" ]; then if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then if [ -n "${{ inputs.langflow-version }}" ]; then echo "✅ PyPI installation tests passed" @@ -400,4 +379,18 @@ jobs: else echo "✅ All cross-platform tests passed - PyPI upload can proceed" fi + elif [ "$result" = "failure" ]; then + if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then + if [ -n "${{ inputs.langflow-version }}" ]; then + echo "⚠️ PyPI installation tests had failures (some may be continue-on-error)" + else + echo "⚠️ Source build and installation tests had failures (some may be continue-on-error)" + fi + else + echo "⚠️ Cross-platform tests had failures (checking if continue-on-error allows PyPI upload)" + fi + # Don't exit 1 here - let continue-on-error handle the workflow flow + else + echo "❌ Cross-platform tests were cancelled or skipped" + exit 1 fi \ No newline at end of file