From 5ebd298463e5cc3043fcc71e8358695b7b72307f Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Mon, 30 Oct 2023 20:42:33 -0300 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=94=A5=20refactor(service.py):=20remo?= =?UTF-8?q?ve=20unnecessary=20code=20that=20pops=20"page"=20and=20"limit"?= =?UTF-8?q?=20parameters=20from=20params=20dictionary?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The code was removing "page" and "limit" parameters from the params dictionary, but these parameters were not being used afterwards. Removing this unnecessary code improves code readability and maintainability. --- src/backend/langflow/services/store/service.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/backend/langflow/services/store/service.py b/src/backend/langflow/services/store/service.py index f70c7367d..c1a417b5f 100644 --- a/src/backend/langflow/services/store/service.py +++ b/src/backend/langflow/services/store/service.py @@ -176,9 +176,6 @@ class StoreService(Service): f"{self.base_url}/users/me", api_key, params={"fields": "id"} ) params["filter"] = json.dumps({"user_created": {"_eq": user_data["id"]}}) - # Get the - params.pop("page", None) - params.pop("limit", None) params["fields"] = ["id"] else: From 79bd78613b63ef0a52c68f6b9f279ddd66ab1ebe Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Mon, 30 Oct 2023 20:57:21 -0300 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=94=A5=20refactor(service.py):=20remo?= =?UTF-8?q?ve=20redundant=20assignment=20to=20params["fields"]=20in=20Stor?= =?UTF-8?q?eService=20class?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/backend/langflow/services/store/service.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/backend/langflow/services/store/service.py b/src/backend/langflow/services/store/service.py index c1a417b5f..1e9386ff2 100644 --- a/src/backend/langflow/services/store/service.py +++ b/src/backend/langflow/services/store/service.py @@ -176,8 +176,6 @@ class StoreService(Service): f"{self.base_url}/users/me", api_key, params={"fields": "id"} ) params["filter"] = json.dumps({"user_created": {"_eq": user_data["id"]}}) - - params["fields"] = ["id"] else: params["filter"] = params["filter"] = json.dumps( {"status": {"_in": ["public", "Public"]}}