From 3925d15eaabef69622e29880ebc81a2e84aa72b2 Mon Sep 17 00:00:00 2001 From: cristhianzl Date: Mon, 3 Jun 2024 18:47:57 -0300 Subject: [PATCH] =?UTF-8?q?=E2=9C=85=20(index.tsx):=20add=20data-testid=20?= =?UTF-8?q?attribute=20to=20save=20button=20for=20better=20testability=20?= =?UTF-8?q?=E2=9C=85=20(flowSettings.spec.ts):=20update=20test=20to=20use?= =?UTF-8?q?=20data-testid=20for=20save=20button=20click?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/modals/flowSettingsModal/index.tsx | 1 + src/frontend/tests/end-to-end/flowSettings.spec.ts | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/frontend/src/modals/flowSettingsModal/index.tsx b/src/frontend/src/modals/flowSettingsModal/index.tsx index ea4ad09cb..961cdbd6e 100644 --- a/src/frontend/src/modals/flowSettingsModal/index.tsx +++ b/src/frontend/src/modals/flowSettingsModal/index.tsx @@ -75,6 +75,7 @@ export default function FlowSettingsModal({ disabled={nameLists.includes(name) && name !== currentFlow!.name} onClick={handleClick} type="submit" + data-testid="save-flow-settings-button" > Save diff --git a/src/frontend/tests/end-to-end/flowSettings.spec.ts b/src/frontend/tests/end-to-end/flowSettings.spec.ts index 607c64677..6f60c3410 100644 --- a/src/frontend/tests/end-to-end/flowSettings.spec.ts +++ b/src/frontend/tests/end-to-end/flowSettings.spec.ts @@ -43,9 +43,8 @@ test("flowSettings", async ({ page }) => { .fill( "Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test Flow Name Test", ); - + await page.getByTestId("save-flow-settings-button").click(); await page.getByText("Save").last().click(); - await page.waitForTimeout(1000); await page.getByText("Changes saved successfully").isVisible();