From 3f427555f4f4ed0316dd380c502591b70f616ce1 Mon Sep 17 00:00:00 2001
From: Christophe Bornet <cbornet@hotmail.com>
Date: Thu, 13 Mar 2025 11:01:39 +0100
Subject: [PATCH] ref: Refactor tracing service (#7011)

* Refactor tracing service

* Remove start, flush and stop
---
 .../base/langflow/services/tracing/service.py | 37 ++++---------------
 1 file changed, 7 insertions(+), 30 deletions(-)

diff --git a/src/backend/base/langflow/services/tracing/service.py b/src/backend/base/langflow/services/tracing/service.py
index 9f02ca87d..cb3882d10 100644
--- a/src/backend/base/langflow/services/tracing/service.py
+++ b/src/backend/base/langflow/services/tracing/service.py
@@ -60,35 +60,10 @@ class TracingService(Service):
         self.project_name: str | None = None
         self._tracers: dict[str, BaseTracer] = {}
         self._logs: dict[str, list[Log | dict[Any, Any]]] = defaultdict(list)
-        self.running = False
         self.end_trace_tasks: set[asyncio.Task] = set()
         self.deactivated = self.settings_service.settings.deactivate_tracing
         self.session_id: str | None = None
 
-    async def start(self) -> None:
-        if self.running:
-            return
-        try:
-            self.running = True
-        except Exception:  # noqa: BLE001
-            logger.exception("Error starting tracing service")
-
-    async def flush(self) -> None:
-        # This method is kept for API compatibility but now has minimal implementation
-        try:
-            # Wait for any pending trace tasks to complete
-            if self.end_trace_tasks:
-                await asyncio.gather(*self.end_trace_tasks, return_exceptions=True)
-        except Exception:  # noqa: BLE001
-            logger.exception("Error flushing logs")
-
-    async def stop(self) -> None:
-        try:
-            self.running = False
-            await self.flush()
-        except Exception:  # noqa: BLE001
-            logger.exception("Error stopping tracing service")
-
     def _reset_io(self) -> None:
         self.inputs = defaultdict(dict)
         self.inputs_metadata = defaultdict(dict)
@@ -99,14 +74,12 @@ class TracingService(Service):
         if self.deactivated:
             return
         try:
-            await self.start()
-
             self._initialize_langsmith_tracer()
             self._initialize_langwatch_tracer()
             self._initialize_langfuse_tracer()
             self._initialize_arize_phoenix_tracer()
-        except Exception as e:  # noqa: BLE001
-            logger.debug(f"Error initializing tracers: {e}")
+        except Exception:  # noqa: BLE001
+            logger.opt(exception=True).debug("Error initializing tracers")
 
     def _initialize_langsmith_tracer(self) -> None:
         project_name = os.getenv("LANGCHAIN_PROJECT", "Langflow")
@@ -202,7 +175,11 @@ class TracingService(Service):
 
     async def end(self, outputs: dict, error: Exception | None = None) -> None:
         await asyncio.to_thread(self._end_all_traces, outputs, error)
-        await self.stop()
+        try:
+            # Wait for any pending trace tasks to complete
+            await asyncio.gather(*self.end_trace_tasks)
+        except Exception:  # noqa: BLE001
+            logger.exception("Error flushing logs")
 
     def add_log(self, trace_name: str, log: Log) -> None:
         self._logs[trace_name].append(log)