From 4045d233c7006378f8d35495d96e28607fa53123 Mon Sep 17 00:00:00 2001 From: Cristhian Zanforlin Lousa Date: Fri, 7 Jul 2023 20:55:56 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(parameterComponent/index.tsx?= =?UTF-8?q?):=20remove=20unused=20useState=20and=20useEffect=20dependencie?= =?UTF-8?q?s=20to=20improve=20code=20readability=20=F0=9F=90=9B=20fix(Edit?= =?UTF-8?q?NodeModal/index.tsx):=20remove=20unused=20useState=20and=20useE?= =?UTF-8?q?ffect=20dependencies=20to=20improve=20code=20readability?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../components/parameterComponent/index.tsx | 13 ++++++------- src/frontend/src/modals/EditNodeModal/index.tsx | 4 +--- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx index 40015024d..2e6d694f7 100644 --- a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx @@ -47,6 +47,7 @@ export default function ParameterComponent({ const { closePopUp } = useContext(PopUpContext); const { setTabsState, tabId, save } = useContext(TabsContext); + useEffect(() => { if (ref.current && ref.current.offsetTop && ref.current.clientHeight) { setPosition(ref.current.offsetTop + ref.current.clientHeight / 2); @@ -58,11 +59,11 @@ export default function ParameterComponent({ updateNodeInternals(data.id); }, [data.id, position, updateNodeInternals]); - const [enabled, setEnabled] = useState( - data.node.template[name]?.value ?? false - ); - useEffect(() => {}, [closePopUp, data.node.template]); + useEffect(() => { + + }, [closePopUp, data.node.template]); + const { reactFlowInstance } = useContext(typesContext); let disabled = @@ -239,12 +240,10 @@ export default function ParameterComponent({
{ handleOnNewValue(t); - setEnabled(t); }} - size="large" />
diff --git a/src/frontend/src/modals/EditNodeModal/index.tsx b/src/frontend/src/modals/EditNodeModal/index.tsx index 7bf8f54df..47e0db079 100644 --- a/src/frontend/src/modals/EditNodeModal/index.tsx +++ b/src/frontend/src/modals/EditNodeModal/index.tsx @@ -55,7 +55,6 @@ export default function EditNodeModal({ data }: { data: NodeDataType }) { const { closePopUp } = useContext(PopUpContext); const { types } = useContext(typesContext); const ref = useRef(); - const [enabled, setEnabled] = useState(null); const { setTabsState, tabId, save } = useContext(TabsContext); const { reactFlowInstance } = useContext(typesContext); @@ -202,10 +201,9 @@ export default function EditNodeModal({ data }: { data: NodeDataType }) { {" "} { handleOnNewValue(t, n); - setEnabled(t); }} size="small" />