jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

refactor: ⚡️ Speed up method Graph.sort_chat_inputs_first by 152% (#5263)

Browse source 
* ⚡️ Speed up method `Graph.sort_chat_inputs_first` by 152%
Certainly! Optimization in this large context requires streamlining I/O operations, leveraging efficient data structures, and minimizing repeated operations. Below is the optimized version that focuses on these aspects.



### Explanation of Improvements.
1. **Remove Unnecessary Attributes**: Removed unused attributes to reduce memory footprint and complexity.
2. **Streamlined `__deepcopy__` Method**: Combined conditional logic to avoid redundant checks.
3. **Efficient Loop Handling**: Used list comprehensions and in-place modifications for the layers in the `sort_chat_inputs_first` method to reduce additional loops and copies.
4. **Exception Handling**: Simplified exception raise statements for clarity.

These changes focus on minimizing redundant operations, optimizing data structure usages, and ensuring that the operations performed are as direct and efficient as possible. Further optimization could be performed by profiling this code with real data to identify specific bottlenecks.

* Remove extra imports

* fix lint issues

---------

Co-authored-by: codeflash-ai[bot] <148906541+codeflash-ai[bot]@users.noreply.github.com>
This commit is contained in:
Saurabh Misra 2024-12-18 06:55:48 -08:00 • committed by GitHub
commit 40d179ddc4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/backend/base/langflow/graph/graph/base.py
View file

@ -1953,23 +1953,22 @@ class Graph:
return [layer for layer in refined_layers if layer]
def sort_chat_inputs_first(self, vertices_layers: list[list[str]]) -> list[list[str]]:
# First check if any chat inputs have dependencies
chat_inputs = []
for layer in vertices_layers:
for vertex_id in layer:
if "ChatInput" in vertex_id and self.get_predecessors(self.get_vertex(vertex_id)):
return vertices_layers
if "ChatInput" in vertex_id:
chat_inputs.append(vertex_id)
if not chat_inputs:
return vertices_layers
# If no chat inputs have dependencies, move them to first layer
chat_inputs_first = []
for layer in vertices_layers:
layer_chat_inputs_first = [vertex_id for vertex_id in layer if "ChatInput" in vertex_id]
chat_inputs_first.extend(layer_chat_inputs_first)
for vertex_id in layer_chat_inputs_first:
# Remove the ChatInput from the layer
layer.remove(vertex_id)
if not chat_inputs_first:
return vertices_layers
layer[:] = [v for v in layer if v not in layer_chat_inputs_first]
return [chat_inputs_first, *vertices_layers]