diff --git a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx index 5360849b5..779034c6d 100644 --- a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx @@ -1,4 +1,3 @@ -import { cloneDeep } from "lodash"; import React, { ReactNode, useContext, @@ -46,7 +45,6 @@ export default function ParameterComponent({ left, id, data, - setData, tooltipTitle, title, color, @@ -95,9 +93,7 @@ export default function ParameterComponent({ newValue: string | string[] | boolean | Object[] ): void => { takeSnapshot(); - let newData = cloneDeep(data); - newData.node!.template[name].value = newValue; - setData(newData); + data.node!.template[name].value = newValue; // Set state to pending //@ts-ignore setTabsState((prev: TabsState) => { @@ -444,9 +440,6 @@ export default function ParameterComponent({ field_name={name} setNodeClass={(nodeClass) => { data.node = nodeClass; - const clone = cloneDeep(data); - clone.node = nodeClass; - setData(clone); }} nodeClass={data.node} disabled={disabled} diff --git a/src/frontend/src/CustomNodes/GenericNode/index.tsx b/src/frontend/src/CustomNodes/GenericNode/index.tsx index ce374021e..c543fb27b 100644 --- a/src/frontend/src/CustomNodes/GenericNode/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/index.tsx @@ -23,7 +23,7 @@ import { classNames, toTitleCase } from "../../utils/utils"; import ParameterComponent from "./components/parameterComponent"; export default function GenericNode({ - data: olddata, + data, xPos, yPos, selected, @@ -33,7 +33,6 @@ export default function GenericNode({ xPos: number; yPos: number; }): JSX.Element { - const [data, setData] = useState(olddata); const { updateFlow, flows, tabId } = useContext(TabsContext); const updateNodeInternals = useUpdateNodeInternals(); const { types, deleteNode, reactFlowInstance, setFilterEdge, getFilterEdge } = @@ -89,7 +88,6 @@ export default function GenericNode({ // State for outline color const { sseData, isBuilding } = useSSE(); useEffect(() => { - olddata.node = data.node; let myFlow = flows.find((flow) => flow.id === tabId); if (reactFlowInstance && myFlow) { let flow = cloneDeep(myFlow); @@ -132,7 +130,6 @@ export default function GenericNode({ 0 diff --git a/src/frontend/src/modals/EditNodeModal/index.tsx b/src/frontend/src/modals/EditNodeModal/index.tsx index 6e00e6504..bf1d5506f 100644 --- a/src/frontend/src/modals/EditNodeModal/index.tsx +++ b/src/frontend/src/modals/EditNodeModal/index.tsx @@ -48,14 +48,12 @@ const EditNodeModal = forwardRef( ( { data, - setData, nodeLength, children, open, onClose, }: { data: NodeDataType; - setData: (data: NodeDataType) => void; nodeLength: number; children: ReactNode; open?: boolean; diff --git a/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx index ffd5ea2cb..d61392683 100644 --- a/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx @@ -19,7 +19,6 @@ import { classNames, getRandomKeyByssmm } from "../../../../utils/utils"; export default function NodeToolbarComponent({ data, - setData, deleteNode, position, setShowNode, @@ -235,7 +234,6 @@ export default function NodeToolbarComponent({ {showModalAdvanced && ( { diff --git a/src/frontend/src/types/components/index.ts b/src/frontend/src/types/components/index.ts index 7f53ff77f..865cc1f5e 100644 --- a/src/frontend/src/types/components/index.ts +++ b/src/frontend/src/types/components/index.ts @@ -38,7 +38,6 @@ export type DropDownComponentType = { }; export type ParameterComponentType = { data: NodeDataType; - setData: (value: NodeDataType) => void; title: string; id: sourceHandleType | targetHandleType; color: string; @@ -433,7 +432,6 @@ export type fileCardPropsType = { export type nodeToolbarPropsType = { data: NodeDataType; deleteNode: (idx: string) => void; - setData: (newState: NodeDataType) => void; position: XYPosition; setShowNode: (boolean: any) => void; numberOfHandles: boolean[] | [];