From 4995a196098a827867bbf84edc0de6f2b1863b40 Mon Sep 17 00:00:00 2001 From: Cristhian Zanforlin Lousa Date: Wed, 7 May 2025 17:13:56 -0300 Subject: [PATCH] test: improve test reliability with updated selectors and utility functions (#7943) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ✨ (auto-login-off.spec.ts): update text selector to match new welcome message for improved test accuracy ♻️ (user-flow-state-cleanup.spec.ts): refactor test to use the new welcome message selector for consistency and accuracy 📝 (autoLogin.spec.ts): add import statement for awaitBootstrapTest utility function to fix test failures due to missing import --- .../tests/core/features/auto-login-off.spec.ts | 9 +++------ .../core/features/user-flow-state-cleanup.spec.ts | 9 ++++----- src/frontend/tests/extended/features/autoLogin.spec.ts | 10 +++++++--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/frontend/tests/core/features/auto-login-off.spec.ts b/src/frontend/tests/core/features/auto-login-off.spec.ts index bedf0c12f..cc677f674 100644 --- a/src/frontend/tests/core/features/auto-login-off.spec.ts +++ b/src/frontend/tests/core/features/auto-login-off.spec.ts @@ -206,12 +206,9 @@ test( expect( ( - await page.waitForSelector( - "text=Begin with a template, or start from scratch.", - { - timeout: 30000, - }, - ) + await page.waitForSelector("text=Welcome to LangFlow", { + timeout: 30000, + }) ).isVisible(), ); diff --git a/src/frontend/tests/core/features/user-flow-state-cleanup.spec.ts b/src/frontend/tests/core/features/user-flow-state-cleanup.spec.ts index 0745eca75..7e75dd5b5 100644 --- a/src/frontend/tests/core/features/user-flow-state-cleanup.spec.ts +++ b/src/frontend/tests/core/features/user-flow-state-cleanup.spec.ts @@ -3,7 +3,7 @@ import { awaitBootstrapTest } from "../../utils/await-bootstrap-test"; test( "flow state should be properly cleaned up between user sessions", - { tag: ["@bug-fix", "@api", "@database"] }, + { tag: ["@release", "@api", "@database"] }, async ({ page }) => { // Disable auto login await page.route("**/api/v1/auto_login", (route) => { @@ -89,10 +89,9 @@ test( // Check that User A starts with an empty flows list expect( ( - await page.waitForSelector( - "text=Begin with a template, or start from scratch.", - { timeout: 30000 }, - ) + await page.waitForSelector("text=Welcome to LangFlow", { + timeout: 30000, + }) ).isVisible(), ); diff --git a/src/frontend/tests/extended/features/autoLogin.spec.ts b/src/frontend/tests/extended/features/autoLogin.spec.ts index 83d1e5dda..6870a7932 100644 --- a/src/frontend/tests/extended/features/autoLogin.spec.ts +++ b/src/frontend/tests/extended/features/autoLogin.spec.ts @@ -1,5 +1,5 @@ import { test } from "@playwright/test"; - +import { awaitBootstrapTest } from "../../utils/await-bootstrap-test"; test.describe( "Auto_login tests", { tag: ["@release", "@api", "@database"] }, @@ -9,7 +9,9 @@ test.describe( "auto_login sign in", { tag: ["@release", "@api", "@database"] }, async ({ page }) => { - await page.goto("/"); + await awaitBootstrapTest(page, { + skipModal: true, + }); await page.getByText("New Flow", { exact: true }).click(); }, ); @@ -18,7 +20,9 @@ test.describe( "auto_login block_admin", { tag: ["@release", "@api", "@database"] }, async ({ page }) => { - await page.goto("/"); + await awaitBootstrapTest(page, { + skipModal: true, + }); await page.getByText("New Flow", { exact: true }).click(); await page.waitForSelector('[data-testid="modal-title"]', { timeout: 5000,