Fix build status class issue in GenericNode component

This commit is contained in:
Gabriel Luiz Freitas Almeida 2024-02-25 18:56:19 -03:00
commit 515b281248

View file

@ -170,7 +170,6 @@ export default function GenericNode({
validationStatus: validationStatusType | null validationStatus: validationStatusType | null
) => { ) => {
const isValid = validationStatus && validationStatus.valid; const isValid = validationStatus && validationStatus.valid;
if (isValid) { if (isValid) {
return "green-status"; return "green-status";
} else if (!isValid && buildStatus === BuildStatus.INACTIVE) { } else if (!isValid && buildStatus === BuildStatus.INACTIVE) {
@ -181,8 +180,10 @@ export default function GenericNode({
return "red-status"; return "red-status";
} else if (!validationStatus) { } else if (!validationStatus) {
return "yellow-status"; return "yellow-status";
} else { } else if (buildStatus === BuildStatus.BUILDING) {
return "status-build-animation"; return "status-build-animation";
} else {
return "green-status";
} }
}; };
@ -203,6 +204,7 @@ export default function GenericNode({
validationStatus: validationStatusType | null validationStatus: validationStatusType | null
) => { ) => {
let isInvalid = validationStatus && !validationStatus.valid; let isInvalid = validationStatus && !validationStatus.valid;
if (buildStatus === BuildStatus.INACTIVE && isInvalid) { if (buildStatus === BuildStatus.INACTIVE && isInvalid) {
// INACTIVE should have its own class // INACTIVE should have its own class
return "inactive-status"; return "inactive-status";
@ -222,11 +224,17 @@ export default function GenericNode({
buildStatus: BuildStatus | undefined, buildStatus: BuildStatus | undefined,
validationStatus: validationStatusType | null validationStatus: validationStatusType | null
) => { ) => {
const specificClassFromBuildStatus = getSpecificClassFromBuildStatus(
buildStatus,
validationStatus
);
const baseBorderClass = getBaseBorderClass(selected);
const nodeSizeClass = getNodeSizeClass(showNode);
return classNames( return classNames(
getBaseBorderClass(selected), baseBorderClass,
getNodeSizeClass(showNode), nodeSizeClass,
"generic-node-div", "generic-node-div",
getSpecificClassFromBuildStatus(buildStatus, validationStatus) specificClassFromBuildStatus
); );
}; };
@ -479,6 +487,7 @@ export default function GenericNode({
isBuilding isBuilding
) )
return; return;
buildFlow(data.id); buildFlow(data.id);
}} }}
> >