♻️ (tableComponent): remove unnecessary console.log and fix formatting
✨ (use-row-data): add open parameter to useRowData for reactivity ♻️ (editNodeModal): clone data before assigning to myData.current ✅ (dropdownComponent.spec): add waitForTimeout to stabilize tests
This commit is contained in:
parent
a17910a535
commit
532eaca071
4 changed files with 11 additions and 9 deletions
|
|
@ -61,8 +61,6 @@ const TableComponent = forwardRef<
|
||||||
}}
|
}}
|
||||||
ref={ref}
|
ref={ref}
|
||||||
getRowId={(params) => {
|
getRowId={(params) => {
|
||||||
console.log(params);
|
|
||||||
|
|
||||||
return params.data.id;
|
return params.data.id;
|
||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
|
|
|
||||||
|
|
@ -2,7 +2,7 @@ import { useMemo } from "react";
|
||||||
import { LANGFLOW_SUPPORTED_TYPES } from "../../../constants/constants";
|
import { LANGFLOW_SUPPORTED_TYPES } from "../../../constants/constants";
|
||||||
import { TemplateVariableType } from "../../../types/api";
|
import { TemplateVariableType } from "../../../types/api";
|
||||||
|
|
||||||
const useRowData = (myData) => {
|
const useRowData = (myData, open) => {
|
||||||
const rowData = useMemo(() => {
|
const rowData = useMemo(() => {
|
||||||
return Object.keys(myData.current.node!.template)
|
return Object.keys(myData.current.node!.template)
|
||||||
.filter((key: string) => {
|
.filter((key: string) => {
|
||||||
|
|
@ -29,7 +29,7 @@ const useRowData = (myData) => {
|
||||||
id: key,
|
id: key,
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
}, [myData.current.node!.template]);
|
}, [open]);
|
||||||
|
|
||||||
return rowData;
|
return rowData;
|
||||||
};
|
};
|
||||||
|
|
|
||||||
|
|
@ -1,4 +1,5 @@
|
||||||
import { ColDef } from "ag-grid-community";
|
import { ColDef } from "ag-grid-community";
|
||||||
|
import { cloneDeep } from "lodash";
|
||||||
import { forwardRef, useEffect, useRef } from "react";
|
import { forwardRef, useEffect, useRef } from "react";
|
||||||
import IconComponent from "../../components/genericIconComponent";
|
import IconComponent from "../../components/genericIconComponent";
|
||||||
import TableComponent from "../../components/tableComponent";
|
import TableComponent from "../../components/tableComponent";
|
||||||
|
|
@ -22,7 +23,7 @@ const EditNodeModal = forwardRef(
|
||||||
setOpen: (open: boolean) => void;
|
setOpen: (open: boolean) => void;
|
||||||
data: NodeDataType;
|
data: NodeDataType;
|
||||||
},
|
},
|
||||||
ref
|
ref,
|
||||||
) => {
|
) => {
|
||||||
const nodes = useFlowStore((state) => state.nodes);
|
const nodes = useFlowStore((state) => state.nodes);
|
||||||
|
|
||||||
|
|
@ -43,16 +44,17 @@ const EditNodeModal = forwardRef(
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (open) {
|
if (open) {
|
||||||
myData.current = data;
|
const cloneData = cloneDeep(dataFromStore ?? data);
|
||||||
|
myData.current = cloneData;
|
||||||
}
|
}
|
||||||
}, [open]);
|
}, [open]);
|
||||||
|
|
||||||
const rowData = useRowData(myData);
|
const rowData = useRowData(myData, open);
|
||||||
|
|
||||||
const columnDefs: ColDef[] = useColumnDefs(
|
const columnDefs: ColDef[] = useColumnDefs(
|
||||||
myData,
|
myData,
|
||||||
handleOnNewValue,
|
handleOnNewValue,
|
||||||
changeAdvanced
|
changeAdvanced,
|
||||||
);
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
|
|
@ -110,7 +112,7 @@ const EditNodeModal = forwardRef(
|
||||||
<BaseModal.Footer submit={{ label: "Save Changes" }} />
|
<BaseModal.Footer submit={{ label: "Save Changes" }} />
|
||||||
</BaseModal>
|
</BaseModal>
|
||||||
);
|
);
|
||||||
}
|
},
|
||||||
);
|
);
|
||||||
|
|
||||||
export default EditNodeModal;
|
export default EditNodeModal;
|
||||||
|
|
|
||||||
|
|
@ -62,6 +62,8 @@ test("dropDownComponent", async ({ page }) => {
|
||||||
expect(false).toBeTruthy();
|
expect(false).toBeTruthy();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
await page.waitForTimeout(1000);
|
||||||
|
|
||||||
await page.getByTestId("more-options-modal").click();
|
await page.getByTestId("more-options-modal").click();
|
||||||
await page.getByTestId("edit-button-modal").click();
|
await page.getByTestId("edit-button-modal").click();
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue