From 59033785035bd2f11351aa44d7dd7a4d26f6d3ea Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Tue, 5 Sep 2023 14:46:55 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(process.py):=20remove=20unne?= =?UTF-8?q?cessary=20else=20statement=20to=20improve=20code=20readability?= =?UTF-8?q?=20and=20semantics=20=F0=9F=90=9B=20fix(process.py):=20update?= =?UTF-8?q?=20session=5Fmanager.update=5Fsession()=20method=20signature=20?= =?UTF-8?q?to=20match=20the=20new=20implementation=20=F0=9F=90=9B=20fix(wo?= =?UTF-8?q?rker.py):=20update=20session=5Fmanager.update=5Fsession()=20met?= =?UTF-8?q?hod=20signature=20to=20match=20the=20new=20implementation=20?= =?UTF-8?q?=F0=9F=90=9B=20fix(test=5Fprocess.py):=20update=20session=5Fman?= =?UTF-8?q?ager.build=5Fkey()=20and=20session=5Fmanager.clear=5Fsession()?= =?UTF-8?q?=20method=20calls=20to=20match=20the=20new=20implementation?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/backend/langflow/processing/process.py | 6 +----- src/backend/langflow/worker.py | 4 +--- tests/test_process.py | 7 ++++--- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/backend/langflow/processing/process.py b/src/backend/langflow/processing/process.py index 8e0e9771e..10bdbd876 100644 --- a/src/backend/langflow/processing/process.py +++ b/src/backend/langflow/processing/process.py @@ -192,17 +192,13 @@ async def process_graph_cached( session_id = session_manager.generate_key( session_id=session_id, data_graph=data_graph ) - else: - session_id = session_manager.build_key(session_id, data_graph) # Load the graph using SessionManager langchain_object, artifacts = session_manager.load_session(session_id, data_graph) processed_inputs = process_inputs(inputs, artifacts) result = generate_result(langchain_object, processed_inputs) # langchain_object is now updated with the new memory # we need to update the cache with the updated langchain_object - session_manager.update_session( - session_id, data_graph, (langchain_object, artifacts) - ) + session_manager.update_session(session_id, (langchain_object, artifacts)) return Result(result, session_id) diff --git a/src/backend/langflow/worker.py b/src/backend/langflow/worker.py index 4790090f0..2b66b160c 100644 --- a/src/backend/langflow/worker.py +++ b/src/backend/langflow/worker.py @@ -50,8 +50,6 @@ def process_graph_cached_task( result = generate_result(langchain_object, processed_inputs) # langchain_object is now updated with the new memory # we need to update the cache with the updated langchain_object - session_manager.update_session( - session_id, data_graph, (langchain_object, artifacts) - ) + session_manager.update_session(session_id, (langchain_object, artifacts)) return result, session_id diff --git a/tests/test_process.py b/tests/test_process.py index 6d396f974..0628676ee 100644 --- a/tests/test_process.py +++ b/tests/test_process.py @@ -217,14 +217,15 @@ def test_load_langchain_object_with_no_cached_session(client, basic_graph_data): # Provide a non-existent session_id session_manager = get_session_manager() session_id1 = "non-existent-session-id" + session_id = session_manager.build_key(session_id1, basic_graph_data) langchain_object1, artifacts1 = session_manager.load_session( - session_id1, basic_graph_data + session_id, basic_graph_data ) # Clear the cache - session_manager.clear_session(session_id1, basic_graph_data) + session_manager.clear_session(session_id) # Use the new session_id to get the langchain_object again langchain_object2, artifacts2 = session_manager.load_session( - session_id1, basic_graph_data + session_id, basic_graph_data ) assert id(langchain_object1) != id(