From 5ad48b42127c3d8df6c4c75cd9a9196c478c1765 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Wed, 4 Sep 2024 16:12:19 -0300 Subject: [PATCH] chore: update TextInput and TextOutput components to use MultilineInput (#3664) chore: Update TextInput and TextOutput components to use MultilineInput instead of MessageTextInput --- src/backend/base/langflow/components/inputs/TextInput.py | 4 ++-- .../base/langflow/components/outputs/TextOutput.py | 4 ++-- src/frontend/package-lock.json | 6 ------ src/frontend/tests/end-to-end/Blog Writer.spec.ts | 3 +-- src/frontend/tests/end-to-end/freeze.spec.ts | 6 +++--- src/frontend/tests/end-to-end/generalBugs-shard-5.spec.ts | 7 ++----- src/frontend/tests/end-to-end/stop-building.spec.ts | 2 +- src/frontend/tests/end-to-end/textInputOutput.spec.ts | 8 ++++---- 8 files changed, 15 insertions(+), 25 deletions(-) diff --git a/src/backend/base/langflow/components/inputs/TextInput.py b/src/backend/base/langflow/components/inputs/TextInput.py index 6495f9ab6..43a2a0b36 100644 --- a/src/backend/base/langflow/components/inputs/TextInput.py +++ b/src/backend/base/langflow/components/inputs/TextInput.py @@ -1,5 +1,5 @@ from langflow.base.io.text import TextComponent -from langflow.io import MessageTextInput, Output +from langflow.io import MultilineInput, Output from langflow.schema.message import Message @@ -10,7 +10,7 @@ class TextInputComponent(TextComponent): name = "TextInput" inputs = [ - MessageTextInput( + MultilineInput( name="input_value", display_name="Text", info="Text to be passed as input.", diff --git a/src/backend/base/langflow/components/outputs/TextOutput.py b/src/backend/base/langflow/components/outputs/TextOutput.py index ee8276b42..e387d50fb 100644 --- a/src/backend/base/langflow/components/outputs/TextOutput.py +++ b/src/backend/base/langflow/components/outputs/TextOutput.py @@ -1,5 +1,5 @@ from langflow.base.io.text import TextComponent -from langflow.io import MessageTextInput, Output +from langflow.io import MultilineInput, Output from langflow.schema.message import Message @@ -10,7 +10,7 @@ class TextOutputComponent(TextComponent): name = "TextOutput" inputs = [ - MessageTextInput( + MultilineInput( name="input_value", display_name="Text", info="Text to be passed as output.", diff --git a/src/frontend/package-lock.json b/src/frontend/package-lock.json index 5dddee9ed..493e02b23 100644 --- a/src/frontend/package-lock.json +++ b/src/frontend/package-lock.json @@ -13072,12 +13072,6 @@ "integrity": "sha512-w+eufiZ1WuJYgPXbV/PO3NCMEc3xqylkKHzp8bxp1uW4qaSNQUkwmLLEc3kKsfz8lpV1F8Ht3U1Cm+9Srog2ug==", "license": "(MIT AND Zlib)" }, - "node_modules/pako": { - "version": "2.1.0", - "resolved": "https://registry.npmjs.org/pako/-/pako-2.1.0.tgz", - "integrity": "sha512-w+eufiZ1WuJYgPXbV/PO3NCMEc3xqylkKHzp8bxp1uW4qaSNQUkwmLLEc3kKsfz8lpV1F8Ht3U1Cm+9Srog2ug==", - "license": "(MIT AND Zlib)" - }, "node_modules/parent-module": { "version": "1.0.1", "resolved": "https://registry.npmjs.org/parent-module/-/parent-module-1.0.1.tgz", diff --git a/src/frontend/tests/end-to-end/Blog Writer.spec.ts b/src/frontend/tests/end-to-end/Blog Writer.spec.ts index 139ea1bc6..04a791bf2 100644 --- a/src/frontend/tests/end-to-end/Blog Writer.spec.ts +++ b/src/frontend/tests/end-to-end/Blog Writer.spec.ts @@ -73,8 +73,7 @@ test("Blog Writer", async ({ page }) => { .fill("https://www.originaldiving.com/blog/top-ten-turtle-facts"); await page - .getByTestId("popover-anchor-input-input_value") - .nth(0) + .getByTestId("textarea_str_input_value") .fill( "Use the references above for style to write a new blog/tutorial about turtles. Suggest non-covered topics.", ); diff --git a/src/frontend/tests/end-to-end/freeze.spec.ts b/src/frontend/tests/end-to-end/freeze.spec.ts index 40aab7677..04685cad5 100644 --- a/src/frontend/tests/end-to-end/freeze.spec.ts +++ b/src/frontend/tests/end-to-end/freeze.spec.ts @@ -203,7 +203,7 @@ test("user must be able to freeze a component", async ({ page }) => { await page.getByTitle("fit view").click(); await page - .getByTestId("popover-anchor-input-input_value") + .getByTestId("textarea_str_input_value") .first() .fill("lorem ipsum"); @@ -232,7 +232,7 @@ test("user must be able to freeze a component", async ({ page }) => { await page.getByText("Close").last().click(); await page.getByText("Close").last().click(); - await page.getByTestId("popover-anchor-input-input_value").first().fill(","); + await page.getByTestId("textarea_str_input_value").first().fill(","); await page.getByTestId("button_run_chat output").click(); @@ -272,7 +272,7 @@ test("user must be able to freeze a component", async ({ page }) => { await page.locator('//*[@id="react-flow-id"]').click(); await page - .getByTestId("popover-anchor-input-input_value") + .getByTestId("textarea_str_input_value") .first() .fill("lorem ipsum"); diff --git a/src/frontend/tests/end-to-end/generalBugs-shard-5.spec.ts b/src/frontend/tests/end-to-end/generalBugs-shard-5.spec.ts index c46a59ff9..1cb1d2b54 100644 --- a/src/frontend/tests/end-to-end/generalBugs-shard-5.spec.ts +++ b/src/frontend/tests/end-to-end/generalBugs-shard-5.spec.ts @@ -192,14 +192,11 @@ test("should be able to see output preview from grouped components", async ({ await elementTextOutputInput.hover(); await page.mouse.up(); - await page - .getByTestId("popover-anchor-input-input_value") - .nth(0) - .fill(randomName); + await page.getByTestId("textarea_str_input_value").nth(0).fill(randomName); await page.waitForTimeout(1000); await page - .getByTestId("popover-anchor-input-input_value") + .getByTestId("textarea_str_input_value") .nth(1) .fill(secondRandomName); await page.waitForTimeout(1000); diff --git a/src/frontend/tests/end-to-end/stop-building.spec.ts b/src/frontend/tests/end-to-end/stop-building.spec.ts index bc8449773..60c64f612 100644 --- a/src/frontend/tests/end-to-end/stop-building.spec.ts +++ b/src/frontend/tests/end-to-end/stop-building.spec.ts @@ -194,7 +194,7 @@ test("user must be able to stop a building", async ({ page }) => { await page.getByTitle("fit view").click(); - await page.getByTestId("popover-anchor-input-input_value").first().fill(","); + await page.getByTestId("textarea_str_input_value").first().fill(","); await page .getByTestId("inputlist_str_urls_0") diff --git a/src/frontend/tests/end-to-end/textInputOutput.spec.ts b/src/frontend/tests/end-to-end/textInputOutput.spec.ts index 3bd06482b..a94d0efc1 100644 --- a/src/frontend/tests/end-to-end/textInputOutput.spec.ts +++ b/src/frontend/tests/end-to-end/textInputOutput.spec.ts @@ -183,8 +183,8 @@ test("TextInputOutputComponent", async ({ page }) => { await page.mouse.up(); await page - .getByTestId("popover-anchor-input-input_value") - .nth(0) + .getByTestId(/^rf__node-TextInput-[a-zA-Z0-9]+$/) + .getByTestId("textarea_str_input_value") .fill("This is a test!"); let outdatedComponents = await page.getByTestId("icon-AlertTriangle").count(); @@ -221,8 +221,8 @@ test("TextInputOutputComponent", async ({ page }) => { await page.keyboard.press("Escape"); await page - .getByTestId("popover-anchor-input-input_value") - .nth(0) + .getByTestId(/^rf__node-TextInput-[a-zA-Z0-9]+$/) + .getByTestId("textarea_str_input_value") .fill("This is a test, again just to be sure!"); await page.getByText("Playground", { exact: true }).click(); await page.getByText("Run Flow", { exact: true }).click();