From 5c38d0223d91c9b47db61d375743bb60e7a58bd8 Mon Sep 17 00:00:00 2001
From: Cristhian Zanforlin Lousa <cristhian.lousa@gmail.com>
Date: Mon, 16 Jun 2025 12:30:02 -0300
Subject: [PATCH] fix(ui): improve SettingsVoiceModal functionality and
 alignment (#8433)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* 🐛 (audio-settings-dialog.tsx): fix alignment offset in DropdownMenuContent component
📝 (audio-settings-dialog.tsx): remove unnecessary check for empty value in handleOpenAIKeyChange function

* ✨ (freeze.spec.ts): add support for adding a flow to test on an empty langflow if the first run langflow is greater than 0

* ✅ (freeze.spec.ts): update timeout values for page.waitForSelector to improve test reliability and prevent false negatives

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
---
 .../audio-settings/audio-settings-dialog.tsx           |  5 ++---
 src/frontend/tests/core/features/freeze.spec.ts        | 10 +++++++---
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/frontend/src/modals/IOModal/components/chatView/chatInput/components/voice-assistant/components/audio-settings/audio-settings-dialog.tsx b/src/frontend/src/modals/IOModal/components/chatView/chatInput/components/voice-assistant/components/audio-settings/audio-settings-dialog.tsx
index d9bb94929..b5f515775 100644
--- a/src/frontend/src/modals/IOModal/components/chatView/chatInput/components/voice-assistant/components/audio-settings/audio-settings-dialog.tsx
+++ b/src/frontend/src/modals/IOModal/components/chatView/chatInput/components/voice-assistant/components/audio-settings/audio-settings-dialog.tsx
@@ -218,7 +218,6 @@ const SettingsVoiceModal = ({
   };
 
   const handleOpenAIKeyChange = (value: string) => {
-    if (!value) return;
     setOpenaiApiKey(value);
   };
 
@@ -263,7 +262,7 @@ const SettingsVoiceModal = ({
         <DropdownMenuContent
           className="w-[324px] rounded-xl shadow-lg"
           sideOffset={18}
-          alignOffset={-54}
+          alignOffset={-60}
           align="end"
         >
           <div ref={popupRef} className="rounded-3xl">
@@ -291,7 +290,7 @@ const SettingsVoiceModal = ({
                     <>
                       <InputComponent
                         isObjectOption={false}
-                        password={false}
+                        password
                         nodeStyle
                         popoverWidth="16rem"
                         placeholder={getPlaceholder(
diff --git a/src/frontend/tests/core/features/freeze.spec.ts b/src/frontend/tests/core/features/freeze.spec.ts
index 016b4c789..f5a1a6dc5 100644
--- a/src/frontend/tests/core/features/freeze.spec.ts
+++ b/src/frontend/tests/core/features/freeze.spec.ts
@@ -164,7 +164,9 @@ test(
 
     await page.getByTestId("button_run_chat output").click();
 
-    await page.waitForSelector("text=built successfully", { timeout: 30000 });
+    await page.waitForSelector("text=built successfully", {
+      timeout: 30000 * 3,
+    });
 
     await page.waitForSelector(
       '[data-testid="output-inspection-output message-chatoutput"]',
@@ -189,7 +191,7 @@ test(
     await page.getByTestId("button_run_chat output").click();
 
     await page.waitForSelector("text=built successfully", {
-      timeout: 30000 * 2,
+      timeout: 30000 * 3,
     });
 
     await page.waitForSelector(
@@ -243,7 +245,9 @@ test(
 
     await page.getByTestId("button_run_chat output").click();
 
-    await page.waitForSelector("text=built successfully", { timeout: 30000 });
+    await page.waitForSelector("text=built successfully", {
+      timeout: 30000 * 3,
+    });
 
     await page.waitForSelector(
       '[data-testid="output-inspection-output message-chatoutput"]',