jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: removed duplicate controls from node toolbar (#7274)

Browse source 
* Removed duplicate elements from node toolbar

* Fixed freeze tests

* Replaced advanced button modal with edit button modal in all tests

* Fixed freeze test

* Fixed tests

* Readded freeze when there is tool mode

---------

Co-authored-by: Carlos Coelho <80289056+carlosrcoelho@users.noreply.github.com>
This commit is contained in:
Lucas Oliveira 2025-03-29 21:54:20 -03:00 • committed by GitHub
commit 5e39d3f1e2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 40 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

53
src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx
View file

@ -578,34 +578,6 @@ const NodeToolbarComponent = memo(
<SelectContentWithoutPortal
className={"relative top-1 w-56 bg-background"}
>
{hasCode && (
<SelectItem value={"code"}>
<ToolbarSelectItem
shortcut={
shortcuts.find((obj) => obj.name === "Code")?.shortcut!
}
value={"Code"}
icon={"Code"}
dataTestId="code-button-modal"
/>
</SelectItem>
)}
{nodeLength > 0 && (
<SelectItem
value={nodeLength === 0 ? "disabled" : "advanced"}
>
<ToolbarSelectItem
shortcut={
shortcuts.find(
(obj) => obj.name === "Advanced Settings",
)?.shortcut!
}
value={"Controls"}
icon={"SlidersHorizontal"}
dataTestId="advanced-button-modal"
/>
</SelectItem>
)}
<SelectItem value={"save"}>
<ToolbarSelectItem
shortcut={
@ -708,17 +680,20 @@ const NodeToolbarComponent = memo(
/>
</SelectItem>
)}
<SelectItem value="freezeAll">
<ToolbarSelectItem
shortcut={
shortcuts.find((obj) => obj.name === "Freeze")?.shortcut!
}
value={"Freeze"}
icon={"FreezeAll"}
dataTestId="freeze-path-button"
style={`${frozen ? " text-ice" : ""} transition-all`}
/>
</SelectItem>
{hasToolMode && (
<SelectItem value="freezeAll">
<ToolbarSelectItem
shortcut={
shortcuts.find((obj) => obj.name === "Freeze")
?.shortcut!
}
value={"Freeze"}
icon={"FreezeAll"}
dataTestId="freeze-path-button"
style={`${frozen ? " text-ice" : ""} transition-all`}
/>
</SelectItem>
)}
<SelectItem value="Download">
<ToolbarSelectItem
shortcut={

3
src/frontend/tests/core/features/chatInputOutputUser-shard-0.spec.ts
View file

@ -31,8 +31,7 @@ test(
await page.waitForSelector("text=Chat Input", { timeout: 30000 });
await page.getByText("Chat Input", { exact: true }).click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByText("Close").last().click();
await page.getByText("Playground", { exact: true }).last().click();

8
src/frontend/tests/core/features/freeze-path.spec.ts
View file

@ -98,13 +98,7 @@ test(
timeout: 3000,
});
await page.getByTestId("more-options-modal").click();
await page.waitForSelector('[data-testid="freeze-path-button"]', {
timeout: 3000,
});
await page.getByTestId("freeze-path-button").click();
await page.getByText("Freeze").first().click();
await page.waitForTimeout(2000);

12
src/frontend/tests/core/features/freeze.spec.ts
View file

@ -262,17 +262,7 @@ test(
await page.getByText("Split Text", { exact: true }).click();
await page.waitForSelector('[data-testid="more-options-modal"]', {
timeout: 1000,
});
await page.getByTestId("more-options-modal").click();
await page.waitForSelector('[data-testid="icon-Snowflake"]', {
timeout: 1000,
});
await page.getByText("Freeze", { exact: true }).first().click();
await page.getByText("Freeze").first().click();
await page.waitForTimeout(3000);

3
src/frontend/tests/core/unit/dropdownComponent.spec.ts
View file

@ -56,8 +56,7 @@ test(
timeout: 3000,
});
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.waitForTimeout(1000);

6
src/frontend/tests/core/unit/floatComponent.spec.ts
View file

@ -60,8 +60,7 @@ test(
expect(value).toBe("-3");
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByText("Close").last().click();
@ -70,8 +69,7 @@ test(
if (elementCount === 0) {
expect(true).toBeTruthy();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByText("Close").last().click();
await page.locator('//*[@id="int_int_seed"]').click();

6
src/frontend/tests/core/unit/inputComponent.spec.ts
View file

@ -40,8 +40,7 @@ test(
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page
.locator('//*[@id="showchroma_server_cors_allow_origins"]')
@ -126,8 +125,7 @@ test(
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByText("Close").last().click();

3
src/frontend/tests/core/unit/inputListComponent.spec.ts
View file

@ -38,8 +38,7 @@ test(
.fill("test2 test2 test2 test2");
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
const value0 = await page.getByTestId("inputlist_str_urls_0").inputValue();
const value1 = await page.getByTestId("inputlist_str_urls_1").inputValue();

9
src/frontend/tests/core/unit/intComponent.spec.ts
View file

@ -26,8 +26,7 @@ test("IntComponent", { tag: ["@release", "@workspace"] }, async ({ page }) => {
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByTestId("showmax_tokens").click();
await page.getByText("Close").last().click();
@ -60,8 +59,7 @@ test("IntComponent", { tag: ["@release", "@workspace"] }, async ({ page }) => {
await page.getByTestId("zoom_out").click();
await page.getByTestId("zoom_out").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
value = await page.getByTestId("int_int_edit_max_tokens").inputValue();
@ -139,8 +137,7 @@ test("IntComponent", { tag: ["@release", "@workspace"] }, async ({ page }) => {
if (elementCount === 0) {
expect(true).toBeTruthy();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
const valueEditNode = await page
.getByTestId("int_int_max_tokens")

9
src/frontend/tests/core/unit/keyPairListComponent.spec.ts
View file

@ -27,8 +27,7 @@ test(
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByTestId("showmodel_kwargs").click();
expect(await page.getByTestId("showmodel_kwargs").isChecked()).toBeTruthy();
@ -70,8 +69,7 @@ test(
expect(false).toBeTruthy();
}
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByText("Close").last().click();
@ -81,8 +79,7 @@ test(
expect(true).toBeTruthy();
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.locator('//*[@id="editNodekeypair0"]').click();
await page

3
src/frontend/tests/core/unit/nestedComponent.spec.ts
View file

@ -60,8 +60,7 @@ test(
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByTestId("edit_dict_nesteddict_edit_metadata").last().click();
await page.getByTitle("Switch to tree mode (current mode: text)").click();

6
src/frontend/tests/core/unit/promptModalComponent.spec.ts
View file

@ -82,8 +82,7 @@ test(
expect(false).toBeTruthy();
}
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
value =
(await page
@ -188,8 +187,7 @@ test(
await page.getByText("Close").last().click();
await zoomOut(page, 2);
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.locator('//*[@id="showprompt1"]').click();
expect(

9
src/frontend/tests/core/unit/toggleComponent.spec.ts
View file

@ -29,8 +29,7 @@ test(
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.locator('//*[@id="showload_hidden"]').click();
expect(
@ -74,8 +73,7 @@ test(
await adjustScreenView(page);
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
expect(
await page.getByTestId("toggle_bool_load_hidden").isChecked(),
@ -141,8 +139,7 @@ test(
await page.getByTestId("div-generic-node").click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.locator('//*[@id="showload_hidden"]').click();
expect(

3
src/frontend/tests/extended/features/limit-file-size-upload.spec.ts
View file

@ -41,8 +41,7 @@ test(
await page.waitForSelector("text=Chat Input", { timeout: 30000 });
await page.getByText("Chat Input", { exact: true }).click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByText("Close").last().click();
await page.getByText("Playground", { exact: true }).last().click();

3
src/frontend/tests/extended/regression/general-bugs-shard-3836.spec.ts
View file

@ -27,8 +27,7 @@ test(
await page.waitForSelector("text=Chat Input", { timeout: 30000 });
await page.getByText("Chat Input", { exact: true }).click();
await page.getByTestId("more-options-modal").click();
await page.getByTestId("advanced-button-modal").click();
await page.getByTestId("edit-button-modal").last().click();
await page.getByTestId("showfiles").click();
await page.getByText("Close").last().click();

3
src/frontend/tests/extended/regression/generalBugs-shard-10.spec.ts
View file

@ -66,6 +66,9 @@ test(
await page.getByText("Prompt", { exact: true }).last().click();
await page.waitForSelector('[data-testid="more-options-modal"]', {
timeout: 1000,
});
await page.getByTestId("more-options-modal").click();
await page.getByText("Freeze", { exact: true }).first().click();