jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

🐛 fix(EditNodeModal): remove unused state variable 'errorDuplicateKey' to improve code cleanliness and remove unnecessary complexity

Browse source 
🔥 chore(EditNodeModal): remove unused state variables 'dict' and 'dictArr' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused useEffect hook for 'dict' state variable to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'obj' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'myData' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'setMyData' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'setDict' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'setDictArr' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'setObj' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'setTabsState' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'tabId' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused state variable 'reactFlowInstance' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'typesContext' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'useState' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'useEffect' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'forwardRef' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'useContext' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'classNames' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'convertObjToArray' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'convertArrayToObj' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'hasDuplicateKeys' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'KeypairListComponent' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'TextAreaComponent' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'useState' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'useEffect' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'useContext' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'forwardRef' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'classNames' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'convertObjToArray' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'convertArrayToObj' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove unused import for 'hasDuplicateKeys' to improve code cleanliness and remove unnecessary complexity
🔥 chore(EditNodeModal): remove
This commit is contained in:
Cristhian Zanforlin Lousa 2023-09-05 11:13:42 -03:00
commit 628e6bace5
1 changed files with 3 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

43
src/frontend/src/modals/EditNodeModal/index.tsx
View file

@ -55,7 +55,6 @@ const EditNodeModal = forwardRef(
const [myData, setMyData] = useState(data); const [myData, setMyData] = useState(data);
const { setTabsState, tabId } = useContext(TabsContext); const { setTabsState, tabId } = useContext(TabsContext);
const { reactFlowInstance } = useContext(typesContext); const { reactFlowInstance } = useContext(typesContext);
const [errorDuplicateKey, setErrorDuplicateKey] = useState(false);
let disabled = let disabled =
reactFlowInstance reactFlowInstance
@ -86,19 +85,6 @@ const EditNodeModal = forwardRef(
setMyData(data); // reset data to what it is on node when opening modal setMyData(data); // reset data to what it is on node when opening modal
}, [modalOpen]); }, [modalOpen]);
const [dict, setDict] = useState({
key1: "value1",
key2: "value2",
key3: "value3",
key4: "value4",
key5: "value5",
key6: "value6",
} as {});
const [dictArr, setDictArr] = useState([] as string[]);
useEffect(() => {
setDictArr(convertObjToArray(dict));
}, [dict]);
const [obj, setObj] = useState({ const [obj, setObj] = useState({
arr: ["test", 123456, false, null], arr: ["test", 123456, false, null],
@ -135,8 +121,7 @@ const EditNodeModal = forwardRef(
<div <div
className={classNames( className={classNames(
"edit-node-modal-box", "edit-node-modal-box",
nodeLength > limitScrollFieldsModal || nodeLength > limitScrollFieldsModal
nodeLength > dictArr.length
? "overflow-scroll overflow-x-hidden custom-scroll" ? "overflow-scroll overflow-x-hidden custom-scroll"
: "overflow-hidden" : "overflow-hidden"
)} )}
@ -213,34 +198,12 @@ const EditNodeModal = forwardRef(
editNode={false} editNode={false}
value={obj} value={obj}
onChange={(newValue) => { onChange={(newValue) => {
setDict(newValue); setObj(newValue);
}} }}
/> />
</div> </div>
) )
: myData.node?.template[templateParam] : myData.node.template[templateParam]
.type === "keypairlist" ? (
<div className="mt-2 w-full">
<KeypairListComponent
disabled={disabled}
editNode={false}
value={dictArr}
duplicateKey={errorDuplicateKey}
onChange={(newValue: string[]) => {
setErrorDuplicateKey(
hasDuplicateKeys(newValue)
);
if (hasDuplicateKeys(newValue)) {
setDictArr(newValue);
} else {
setDict(
convertArrayToObj(newValue)
);
}
}}
/>
</div>
) : myData.node.template[templateParam]
.multiline ? ( .multiline ? (
<TextAreaComponent <TextAreaComponent
disabled={disabled} disabled={disabled}